After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 465365 - [PATCH] gtk-doc does not compile
[PATCH] gtk-doc does not compile
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.8
Other All
: Normal normal
: 1.9
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-10 11:43 UTC by Rouslan Solomakhin (Руслан Соломахин)
Modified: 2007-09-23 14:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Proposed patch (1.01 KB, patch)
2007-08-10 17:26 UTC, Rouslan Solomakhin (Руслан Соломахин)
none Details | Review

Description Rouslan Solomakhin (Руслан Соломахин) 2007-08-10 11:43:45 UTC
Please describe the problem:
I kept getting this error in configure step:

onfigure: error: conditional "ENABLE_GTK_DOC" was never defined.
Usually this means the macro was only invoked conditionally.


Steps to reproduce:
1. compile gnome-2.20 moduleset using jhbuild


Actual results:
The above error occurs.

Expected results:
Normal compile.

Does this happen every time?
Yes.

Other information:
See http://jhbuild.bxlug.be/builds/2007-08-10-0002/logs/gtk-doc/#configure for a report.

The problem can be solved using this patch:

--- configure.in.orig   2007-08-10 07:29:59.000000000 -0400
+++ configure.in        2007-08-10 07:27:47.000000000 -0400
@@ -117,6 +117,8 @@ PKG_CHECK_MODULES(TEST_DEPS, glib-2.0 >=
     AM_CONDITIONAL(ENABLE_GTK_DOC, true)
     AM_CONDITIONAL(GTK_DOC_USE_LIBTOOL, test -n "$LIBTOOL")
   ],[
+    AM_CONDITIONAL(ENABLE_GTK_DOC, false)
+    AM_CONDITIONAL(GTK_DOC_USE_LIBTOOL, false)
     AM_CONDITIONAL(BUILD_TESTS, false)
   ]
 )
Comment 1 Yeti 2007-08-10 16:40:36 UTC
[If you attach the patch as a file (Create a New Attachment) it is immediately visible in the bug list that a patch is available, better than cluttering the title.]

Now, since this issue was raised...  putting AM_CONDITIONALs into conditionally executed statements is generally not recommended (precisely because of the requirement that they have to be executed once and only once).  Could you please reformulate the patch to factor the AM_CONDITIONALs out of the branches?
Comment 2 Rouslan Solomakhin (Руслан Соломахин) 2007-08-10 17:26:23 UTC
Created attachment 93449 [details] [review]
Proposed patch
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2007-08-10 17:43:42 UTC
2007-08-10  Stefan Kost  <ensonic@users.sf.net>

	patch by: Rouslan Solomakhin <rouslan@solomakhin.net>

	* configure.in:
	  Fix the build.