After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 465129 - environ symbol portability problem
environ symbol portability problem
Status: RESOLVED WONTFIX
Product: passepartout
Classification: Deprecated
Component: Default
0.8.x
Other Mac OS
: Normal normal
: ---
Assigned To: Sven Herzberg
passepartout-maint
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2007-08-09 18:34 UTC by Daniel Macks
Modified: 2011-02-07 05:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use NSGetEnviron (if available) for environ (1.06 KB, patch)
2007-08-09 18:36 UTC, Daniel Macks 		reviewed Details | Review
...remember to include autoconf header before using its tokens (1.08 KB, patch)
2007-08-09 19:32 UTC, Daniel Macks 		reviewed Details | Review
Proposed patch (1.12 KB, patch)
2009-04-08 09:17 UTC, Sven Herzberg 		none Details | Review

Description Daniel Macks 2007-08-09 18:34:19 UTC 
No such variable or symbol on OS X, gives linker error when linking against things containing processman.o. Isn't that nice?
Comment 1 Daniel Macks 2007-08-09 18:36:25 UTC 
Created attachment 93384 [details] [review]
use NSGetEnviron (if available) for environ
Comment 2 Daniel Macks 2007-08-09 19:32:34 UTC 
Created attachment 93398 [details] [review]
...remember to include autoconf header before using its tokens
Comment 3 Sven Herzberg 2007-08-09 22:35:20 UTC 
I think the code is easier portable if we move to Glib::getenv(): http://www.physics.louisville.edu/help/usr/glibmm-2.4/docs/reference/html/group__MiscUtils.html
Comment 4 Daniel Macks 2007-08-10 22:24:31 UTC 
Sounds like a good solution.
Comment 5 Sven Herzberg 2008-01-09 21:07:48 UTC 
Updating patch status...
Comment 6 Sven Herzberg 2009-04-08 09:17:46 UTC 
Created attachment 132316 [details] [review]
Proposed patch

This patch uses g_listenv() (which doesn't seem to be C++-wrapped yet, but instead provides exactly the C structure that we need).

Daniel, does this look good to you?
Comment 7 Sven Herzberg 2009-04-08 09:34:24 UTC 
Comment on attachment 132316 [details] [review]
Proposed patch

>diff --git a/configure.ac b/configure.ac
>index 9af816e..fb930d2 100644
>--- a/configure.ac
>+++ b/configure.ac
...
>+AM_PATH_GLIB_2_0([2.8])

This has to be "2.8.0", not "2.8"
Comment 8 Daniel Macks 2009-04-08 09:42:25 UTC 
Will be a few days before I will have a chance to test this, but it looks good by eye.
Comment 9 Daniel Macks 2009-04-08 09:47:45 UTC 
Missing g_listenv wrapper in glibmm is Bug #578355, but obviously don't need to wait on that getting fixed since there's an easy work-around.
Comment 10 Sven Herzberg 2009-04-30 10:06:08 UTC 
(In reply to comment #8)
> Will be a few days before I will have a chance to test this, but it looks good
> by eye.

Any results?
Comment 11 Fabio Durán Verdugo 2011-02-07 05:23:49 UTC 
passepartout development has been stalled and it has been unmaintained for a few years now.
Maintainers don't have future development plan so i am closing bugs as WONTFIX.
Please feel free to reopen the bugs in future if anyone takes the responsibility for active development.