After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 465067 - Allow multiple simultaneous esound instances
Allow multiple simultaneous esound instances
Status: RESOLVED FIXED
Product: esound
Classification: Deprecated
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Esound Maintainers
Esound Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-09 15:17 UTC by Lennart Poettering
Modified: 2008-07-15 16:15 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
the patch (1.06 KB, patch)
2007-08-09 15:39 UTC, Lennart Poettering 		committed Details | Review

Description Lennart Poettering 2007-08-09 15:17:02 UTC 
Please merge the patch I attached into upstream esd. It is already
being shipped that way by Ubuntu. It moves the esd socket from /tmp/.esd/socket
to /tmp/.esd-`id -u`/socket, effectively allowing multiple simultaneous esd
instances, one per user.

I need this for getting fast-user-switching working properly in PulseAudio,
because otherwise when multiple PA instances are running only a single one would
be able to emulate esd.

As mentioned, this patch is already merged in Ubuntu's esd version. And I am now merging it into the Fedora version. See:

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251505
Comment 1 Lennart Poettering 2007-08-09 15:39:37 UTC 
Created attachment 93371 [details] [review]
the patch
Comment 2 David Schleef 2007-08-09 21:54:55 UTC 
"malloc(x+40)" for a sprintf buffer?

Otherwise, it looks fine.
Comment 3 Lennart Poettering 2007-08-12 21:29:09 UTC 
I guess Martin was just a little bit lazy. Should be enough space for a printing an int, though, and so I wouldn't care. And, it's certainly not the ugliest code in ESD. ;-)

Do you really need this fixed? Not just Martin is a little bit lazy, I am too. ;-)
Comment 4 David Schleef 2007-08-12 22:11:13 UTC 
I'll fix it when I apply it.  Or maybe not, since it is technically above the coding standards of esound.
Comment 5 Jeffrey Stedfast 2008-07-15 16:15:28 UTC 
committed