After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 463215 - [audioconvert] compile errors
[audioconvert] compile errors
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.14
Other Linux
: Normal normal
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-03 17:55 UTC by Jens Granseuer
Modified: 2007-08-03 19:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
C89 fixes (3.81 KB, patch)
2007-08-03 17:56 UTC, Jens Granseuer
committed Details | Review

Description Jens Granseuer 2007-08-03 17:55:34 UTC
Apparently, audioquantize was already designed with C89 in mind. However, one small issue still slipped through the net:

#define A() int i;
#define B() int j;

when used like this:

{
  A();
  B();
...
}

leads to

{
  int i;;
  int j;
...
}

Unfortunately ; already comprises an instruction which may not be followed by further variable declarations. Patch attached.
Comment 1 Jens Granseuer 2007-08-03 17:56:06 UTC
Created attachment 93049 [details] [review]
C89 fixes
Comment 2 Sebastian Dröge (slomo) 2007-08-03 19:32:39 UTC
Thanks, committed.

2007-08-03  Sebastian Dröge  <slomo@circular-chaos.org>

       Patch by: Jens Granseuer <jensgr at gmx dot net>

       * gst/audioconvert/gstaudioquantize.c:
       Fix C89 incompatibilities and spelling of explanations. Fixes #463215.