After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462465 - g_param_spec_enum should be used for enumerations
g_param_spec_enum should be used for enumerations
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2007-08-01 13:49 UTC by Marco Barisione
Modified: 2007-08-09 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use g_param_spec_enum and g_param_spec_flags for enumerations (17.66 KB, patch)
2007-08-04 17:13 UTC, Marco Barisione 		needs-work Details | Review

Description Marco Barisione 2007-08-01 13:49:42 UTC 
Empathy should use g_param_spec_enum instead of g_param_spec_uint for enumerations. I'm going to write a patch for in in the next days.
Comment 1 Marco Barisione 2007-08-04 17:13:10 UTC 
Created attachment 93090 [details] [review]
Use g_param_spec_enum and g_param_spec_flags for enumerations

Changes:
- Use g_param_spec_enum and g_param_spec_flags
- Generate empathy-enum-types.[ch] and empathy-gtk-enum-types.[ch] using glib-mkenums
- Remove empathy_contact_list_store_get_type() as it's already auto-generated.
- Remove empathy-marshal-main.c and build BUILT_SOURCES (as done by most GNOME modules)

Can I commit this patch?
Comment 2 Xavier Claessens 2007-08-06 10:00:41 UTC 
There is a circular dep to fix in Makefile and " %-marshal-main.c: %-marshal.c %-marshal.h" is not needed anymore. Don't forget to removed empathy-marshal-main.c from SVN.

Please put a link here for the MC bug you mention in the FIXME and don't close this bug until that get fixed.

Otherwise OK to commit.
Comment 3 Marco Barisione 2007-08-07 19:08:58 UTC 
Committed to trunk.

The mission-control sf bug is #1768235 (http://sf.net/tracker/?func=detail&atid=932444&aid=1768235&group_id=190214).
Comment 4 Xavier Claessens 2007-08-09 09:14:58 UTC 
MC Bug fixed in 4.33
Comment 5 Xavier Claessens 2007-08-09 09:35:11 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.