After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 462447 - [patch] epiphany no-history mode
[patch] epiphany no-history mode
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: History
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks: 145386
 
 
Reported: 2007-08-01 12:44 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2007-08-06 10:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
avoids saving history to disk when history is not enabled (812 bytes, patch)
2007-08-01 12:45 UTC, Diego Escalante Urrelo (not reading bugmail) 		none Details | Review
Adds a menu item next to Work Offline and the logic behind (2.35 KB, patch)
2007-08-01 13:14 UTC, Diego Escalante Urrelo (not reading bugmail) 		none Details | Review
A combined patch. (4.50 KB, patch)
2007-08-01 18:11 UTC, Diego Escalante Urrelo (not reading bugmail) 		none Details | Review
backend bits (2.29 KB, patch)
2007-08-01 19:34 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2007-08-01 12:44:12 UTC 
Also known as pr0n mode.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 12:45:50 UTC 
Created attachment 92849 [details] [review]
avoids saving history to disk when history is not enabled

:)
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 12:47:55 UTC 
Ah of course this needs a UI, I'm not sure if this would also require disabling cookies?. I mean allowing them but not storing them on the actual user profile.
Comment 3 Reinout van Schouwen 2007-08-01 12:56:53 UTC 
See also bug 329680 and bug 145386
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 13:08:51 UTC 
Also check bug 455504
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 13:14:27 UTC 
Created attachment 92851 [details] [review]
Adds a menu item next to Work Offline and the logic behind

This is the UI part, note that we would be missing cookie management and caching.
We can name the option "disable history" or something like that maybe?. I have no idea about cookies and even less idea about caching. chpe?
Comment 6 Christian Persch 2007-08-01 17:57:39 UTC 
+	g_object_set (G_OBJECT (history), "enabled", !enabled, NULL);

Let's add the public function to ephy-history.h instead.
Also I think setting the history to disabled should write the history to disk, if it's dirty.

Cookie management is indeed a problem, since it's handled internally by gecko... I don't think we can just turn if off without losing all saved cookies, iirc...
Comment 7 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 18:11:50 UTC 
Created attachment 92870 [details] [review]
A combined patch.

So, what about this one?
Comment 8 Christian Persch 2007-08-01 18:32:59 UTC 
ephy_history_set_enabled should only save if ::dirty is TRUE, no?

And didn't you say the UI would be an extension, and ephy just provide the necessary APIs? :)
Comment 9 Diego Escalante Urrelo (not reading bugmail) 2007-08-01 19:34:47 UTC 
Created attachment 92881 [details] [review]
backend bits

Ok, this should do it.
Comment 10 Diego Escalante Urrelo (not reading bugmail) 2007-08-06 10:30:13 UTC 
Committed. I guess I can close this one, private browsing and other stuff is on other bugs.