GNOME Bugzilla – Bug 461805
The combo cell renderer is broken theme wise
Last modified: 2008-03-16 03:40:15 UTC
Please describe the problem:
The arrow box of the combo cell renderer is not properly sized to fit the row size.
Steps to reproduce:
Does this happen every time?
Created attachment 92702 [details]
Combo cell renderer arrow
Created attachment 99628 [details]
The arrow still broken
This is how it looks with Gtk 2.12.
While the menu of the combo box looks nicer, the arrow is still broken.
Created attachment 99629 [details]
How combo arrows looks with the default xp theme
Created attachment 99630 [details]
How arrows looks with the classic windows theme on xp
Created attachment 104293 [details]
Gtk Combobox on Vista
I can't find a definitive reference for how they should look on Vista, but for reference here is what GtkComboBox looks like on Vista right now.
Created attachment 106830 [details] [review]
Fixes for XP
At least, a patch that fixes the problem partially for XP. A damn frame was being drawn when it shouldn't. Also, the width of the button was incorrect, using correct system metrics now.
Partially fixed in trunk and 2.12 (r19735 and r19734) respectively.
2008-03-08 Alberto Ruiz <firstname.lastname@example.org>
* modules/engines/ms-windows/msw_style.c (draw_shadow):
Do not draw frame if parent if combobox.
Uses scrollbar width system metrics for combobox button.
Fixes #461805 for XP theme engine.
Created attachment 106924 [details] [review]
Fixes combobox child size allocation xthickness overriding
gtk_combo_box_size_allocate was overriding x/y shadow thickness for the list mode.
arc, bug #519410 looks like a duplicate of this, doesn't it? Although there are some additional oddities reported in that bug.
Created attachment 107125 [details] [review]
This patch fixes the classic theme
As soon as #521442 gets fixed, this patch would fix the issue.
*** Bug 519410 has been marked as a duplicate of this bug. ***
Fixed in trunk, revision 19887
2008-03-16 Alberto Ruiz <email@example.com>
* modules/engines/ms-windows/msw_style.c (draw_box) (draw_arrow)
(combo_box_draw_arrow) (setup_msw_rc_style): draw box does more intelligent
separation for the xp theming engine and the classic theme while drawing the
combobox_draw_arrow is not used anymore, commented.
The style has been updated to fix border/thickness glitches in the combobox
according to the fixes commited regarding bug #521442. (bug #461805