GNOME Bugzilla – Bug 461785
Please use libnotify to ask the user about connecting clients instead of popping up a dialog
Last modified: 2013-01-28 18:13:47 UTC
I'd prefer if the vino server would use libnotify to inform the user that a client connected and also ask him via libnotify whether he wants to accept the connection, instead of popping up a dialog in the middle of nothing. Popping up dialogs without any direct user interaction that caused it is never a good idea from a usability point of view I would argue. Thanks, Lennart
*** Bug 461787 has been marked as a duplicate of this bug. ***
This is a good idea, i'd personally prefer this approach. We could live the popup around about one minute or so, and reject the connection when the time expire. But unfortunately libnotify is not a blessed GNOME dependency, so we can't just replace the current dialog for this new one. And i don't want to maintain to pieces of code. So, i prefer to wait until libnotify be a blessed dependency. What do you think, Mark?
Having both would be fine, if only for a small period of time. That would allow us to put pressure getting libnotify in as a blessed dep. gnome-user-share already uses libnotify to ask for write permissions (even though gnome-user-share isn't in GNOME itself yet).
Have in mind that notification daemons may or may not have actions support, so there should still be a fallback.
Created attachment 234538 [details] [review] Use notifications to prompt
Doesn't handle notification daemons that don't support actions, and requires libnotify support.
See https://bugs.launchpad.net/notify-osd/+bug/1107919 about the support for notification-daemons that don't have actions support (eg. notify-osd support).
Comment on attachment 234538 [details] [review] Use notifications to prompt (In reply to comment #7) > See https://bugs.launchpad.net/notify-osd/+bug/1107919 about the support for > notification-daemons that don't have actions support (eg. notify-osd support). Thanks! The patch looks fine, but it would of course be nice to have some feedback from the notify-osd developers to know whether it makes sense to have a fallback implementation. Additionally, if it requires libnotify support, it is probably time to make that a requirement in configure.ac.
(In reply to comment #8) > (From update of attachment 234538 [details] [review]) > (In reply to comment #7) > > See https://bugs.launchpad.net/notify-osd/+bug/1107919 about the support for > > notification-daemons that don't have actions support (eg. notify-osd support). > > Thanks! The patch looks fine, but it would of course be nice to have some > feedback from the notify-osd developers to know whether it makes sense to have > a fallback implementation. Hopefully, we're not the ones that'll have to implement it. > Additionally, if it requires libnotify support, it > is probably time to make that a requirement in configure.ac. I can do that as a separate patch (first require libnotify, then update the vino-prompt code).
(In reply to comment #9) > > (In reply to comment #7) > > > See https://bugs.launchpad.net/notify-osd/+bug/1107919 about the support for > > > notification-daemons that don't have actions support (eg. notify-osd support). > Hopefully, we're not the ones that'll have to implement it. Hmm, the response to that bug was essentially "it is a design decision", urgh. > > Additionally, if it requires libnotify support, it > > is probably time to make that a requirement in configure.ac. > > I can do that as a separate patch (first require libnotify, then update the > vino-prompt code). Yes please. Go ahead with your patches, and I will add the fallback logic, unless you are feeling particularly masochistic!
(In reply to comment #10) > (In reply to comment #9) > > > (In reply to comment #7) > > > > See https://bugs.launchpad.net/notify-osd/+bug/1107919 about the support for > > > > notification-daemons that don't have actions support (eg. notify-osd support). > > Hopefully, we're not the ones that'll have to implement it. > > Hmm, the response to that bug was essentially "it is a design decision", urgh. Which is bizarre for something that should be an implementation detail :) > > > Additionally, if it requires libnotify support, it > > > is probably time to make that a requirement in configure.ac. > > > > I can do that as a separate patch (first require libnotify, then update the > > vino-prompt code). > > Yes please. I'll do that later today. > Go ahead with your patches, and I will add the fallback logic, > unless you are feeling particularly masochistic! And I don't have any Ubuntu around to test this properly...
Created attachment 234638 [details] [review] server: Make libnotify a hard dependency As it's been a blessed dependency for a long while now.
I'll let you implement the fallback, if you fancy it. I personally don't think it's very useful for a core GNOME dependency to implement a fallback for a "GNOME-based" desktop, when a work-around is readily available, but I'll leave that up to you. Attachment 234538 [details] pushed as 875b2a3 - Use notifications to prompt Attachment 234638 [details] pushed as 46c3f82 - server: Make libnotify a hard dependency