After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 461577 - When raise-on-click is FALSE, passive grab is unnecessary
When raise-on-click is FALSE, passive grab is unnecessary
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2007-07-29 19:43 UTC by Soren Sandmann Pedersen
Modified: 2007-08-07 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The patch I'm applying to RHEL 4. (1.01 KB, patch)
2007-07-29 19:44 UTC, Soren Sandmann Pedersen
committed Details | Review

Description Soren Sandmann Pedersen 2007-07-29 19:43:57 UTC
Please describe the problem:
Bug 102209 and bug 115072 decribe an issue which essentially amounts to "to do raise-on-click we need a passive grab on a window, but passive grabs cause funky crossing events in some cases".

In click-to-focus mode metacity works around this by not having the grab on focused windows, but in mouse-focus modes it can't do that since the focused window is not necessarily raised.

However if raise-on-click is FALSE, then we don't need the grab even in mouse-modes. This patch implements that.

The Red Hat bug that prompted this is https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184143




Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Soren Sandmann Pedersen 2007-07-29 19:44:45 UTC
Created attachment 92656 [details] [review]
The patch I'm applying to RHEL 4.
Comment 2 Elijah Newren 2007-07-30 03:23:26 UTC
The patch seems fine to me, but the comments probably need some updating.  In the first case, it'd be nice to have a brief explanation as to why the ungrab is done for two cases and not others (or a link to a bug # if it's not easy to summarize).  In the second case, well, it applies to more than click-to-focus now.
Comment 3 Soren Sandmann Pedersen 2007-08-07 17:36:24 UTC
Tue Aug  7 13:26:49 2007  Søren Sandmann  <sandmann@redhat.com>

	* src/window.c (meta_window_notify_focus): Don't maintain a
	passive grab on windows when raise-on-click is FALSE - bug
	461577.