GNOME Bugzilla – Bug 460422
[audiotestsrc] Add support for float and double output
Last modified: 2007-08-03 19:55:16 UTC
the attached patch adds support for float and double output in audiotestsrc. Apart from weird clipping with
audiotestsrc ! audioconvert ! alsasink
everything seems to be fine.
Not sure what the clipping causes, when writing the sound to a file all samples look fine (but are going over the full range of possible values instead of keeping a bit space around the borders). Lowering the volume of audiotestsrc also helps, output to int16 and then converting to int32 works too... so no idea :/
Using osssink instead does work too so maybe alsa simply can't cope with values going over the complete 32 bit range?
Created attachment 92426 [details] [review]
Created attachment 92544 [details] [review]
small bugfix for white noise
looks quite good, I would like to see symbolic names for format. That looks like a candidate for gst-plugin-base/gst-libs/gst/audio.
Created attachment 92943 [details] [review]
this now uses an enum for the format, adds int32 support and sets the volume property to the default of the GParamSpec instead of 1.0. The latter change fixes the clipping I noticed and it should be ready to commit.
Well, for the enum in libgstaudio: we already have GstRingBufferSpec and GstBufferFormat but that's not really usable here because I use the enum for indexing in a function table.
2007-08-03 Sebastian Dröge <firstname.lastname@example.org>
* gst/audiotestsrc/gstaudiotestsrc.c: (gst_audio_test_src_init),
Add float/double and int32 support to audiotestsrc. Fixes #460422.
Also set the default volume to the default value specified in the