GNOME Bugzilla – Bug 460284
Orca should not allow the user to arrow into the FF3 status bar
Last modified: 2008-07-22 19:28:23 UTC
On certain pages, something is convincing Orca that the next line of content in the page is the status bar. When this occurs, arrowing down from the the last line of the page causes the status bar text to be read. Arrowing down from there moves focus back to the last line of the page. This gives one the impression that they are stuck rather than at the end of the page. An example where this occurs is here: http://www.sun.com/desktop/index.jsp
This can also be reproduced when arrowing from the bottom of a html message in thunderbird.
That's odd.... But true. Thanks for pointing that out!
Created attachment 92660 [details] [review] proposed patch Check that obj is in document content before returning it in findNextCaretInOrder(). Doing so seems to solve the problem for both Firefox and Thunderbird. Mike please test. Thanks!
This seems to work well. It also fixes getting stuck on the "you are on-line" button in thunderbird. The only thing left which is probably a different bug is that you can still get stuck in the "to" field if you up arrow past the top of a thunderbird message that you are reading.
Thanks for testing. Before we declare it a different bug, I'll try to reproduce it. The reason I say that is that it crossed my mind that we might have the very same issue with findPreviousCaretInOrder(), but I couldn't manage to up arrow out of the document frame. I figured, why fix code that ain't broke? Now I'm figuring that I should have tried harder with the up arrow. <grin> Stay tuned....
Okay, I can sometimes arrow into the date field of an HTML message. I just put the very same check into findPreviousCaretInOrder() and that didn't stop the behavior. So something else is going on. Still investigating...
Created attachment 93094 [details] [review] take 2 Perhaps I'm just tired.... But if obj is not in document content, find{Next,Previous}CaretInOrder() should always return None (right??). Seems too easy.... Mike please test. Will what am I missing? Thanks guys!
I tested this with the Thunderbird from yesterday and it does seem to solve the problem I reported.
(In reply to comment #7) > Created an attachment (id=93094) [edit] > take 2 > > Perhaps I'm just tired.... But if obj is not in document content, > find{Next,Previous}CaretInOrder() should always return None (right??). Seems > too easy.... I think find{Next,Previous}CaretInOrder() assume you're starting inside document content, so a check at the beginning for this precondition makes a lot of sense.
Too easy AND makes a lot of sense. I'm definitely scared now. ;-) Patch committed to trunk and to the 2.20 branch. Moving to [pending]. Thanks guys!
I've tested this one and it seems to work as expected.
Thanks Mike. Closing as FIXED.