After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 459618 - ARIA widgets should not consume navigation keys
ARIA widgets should not consume navigation keys
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: 2.20.0
Assigned To: Scott Haeger
Orca Maintainers
Depends on:
Blocks: 423348
 
 
Reported: 2007-07-23 16:25 UTC by Scott Haeger
Modified: 2008-07-22 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
first version of ARIA widgets should not consume navigation keys (1.13 KB, patch)
2007-07-24 19:18 UTC, Scott Haeger
none Details | Review
second version of ARIA widgets should not consume navigation keys (1.13 KB, patch)
2007-07-24 19:24 UTC, Scott Haeger
accepted-commit_now Details | Review

Description Scott Haeger 2007-07-23 16:25:17 UTC
ARIA widgets often use Javascript based key bindings that allow a user to interact with the widget.  These key bindings contend with Orca key bindings which causes the ARIA widgets to be non-interactive.  As outlined in the original bug (bug #423348), we will need to do the following:

1) Not consume arrow keyboard events if we are in a component that handles
caret navigation appropriately

2) Not consume structural keyboard navigation events if we are in a component
that needs to use normal typing keys
Comment 1 Scott Haeger 2007-07-24 19:18:49 UTC
Created attachment 92299 [details] [review]
first version of ARIA widgets should not consume navigation keys

This is a preliminary patch to aid in testing for other ARIA widget bugs.  I am sure this fix will go through several iterations so don't consider this a final fix.
Comment 2 Scott Haeger 2007-07-24 19:24:25 UTC
Created attachment 92301 [details] [review]
second version of ARIA widgets should not consume navigation keys

A better version.
Comment 3 Willie Walker 2007-07-25 19:58:53 UTC
I'm guessing 'xml-roles' is the canonical way to determine if something is an ARIA widget?  If so, this looks like a good patch.  The only potential concern is a roundtrip call per keystroke, but I don't see that being a huge hit right now since we do other round trips in things like useCaretNavigationModel.  Commit!
Comment 4 Scott Haeger 2007-07-25 20:29:09 UTC
committed to repository.