After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 459585 - [basertpdepayload] api without namespace
[basertpdepayload] api without namespace
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2007-07-23 14:35 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2007-08-11 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Description Stefan Sauer (gstreamer, gtkdoc dev) 2007-07-23 14:35:46 UTC
this commit added api which should have a namespace prefix or be private
Comment 1 Wim Taymans 2007-07-23 15:45:15 UTC
It's only a macro, it does not create any new symbols in the .so.
Maybe you prefer to have it refixed so that it does not cause problems when other .h files use the same macro names? Anyway, It's too late now, I guess...
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2007-07-23 17:01:51 UTC
I just stumbled upon it while updating the docs. I could add that to the private section there and put a FIXME:0.11 comment into the code.
Comment 3 Tim-Philipp Müller 2007-08-11 12:43:50 UTC
Let's just deprecate the API which was (presumably) not meant to be exposed (if it was, why does none of the derived eleements use it?) and add some comments to make sure no one uses it. It will be removed in 0.11 automatically then.  If it was indeed meant to be public API we can just add prefixed macros when the need arises:

 2007-08-11  Tim-Philipp Müller  <tim at centricular dot net>

        * docs/libs/gst-plugins-base-libs-sections.txt:
        * gst-libs/gst/rtp/gstbasertpdepayload.c:
        * gst-libs/gst/rtp/gstbasertpdepayload.h:
          Mark as deprecated some macros which were presumably meant to be
          private API and accidentally exposed in the public header file.
          Also actually _init() lock (only works at the moment because the
          struct is zeroed out when created and the initial values in the
          mutex struct are zeroes too). (#459585)