After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 459522 - Plugins should be configurable
Plugins should be configurable
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Sankar P
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-07-23 12:25 UTC by Sankar P
Modified: 2007-07-26 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (5.19 KB, patch)
2007-07-23 12:28 UTC, Sankar P 		none Details | Review
Fix (4.25 KB, patch)
2007-07-26 15:16 UTC, Sankar P 		committed Details | Review

Description Sankar P 2007-07-23 12:25:22 UTC 
Up until Evo 2.11.5, the settings/preferences for each plugin has to sit somewhere in the general plugin preferences page. 

This clutters the UI, is less intuitive etc. 

One should be able to configure the plugin within the plugin manager.
Comment 1 Sankar P 2007-07-23 12:28:48 UTC 
Created attachment 92201 [details] [review]
Fix

Patch to Evo that brings in support to configure plugins individually within the plugin-manager. Any plugin that wants to have its own configure option can do so by implementing e_plugin_lib_configure.

The way in which the plugin's preferences are stored are up to the plugin (as of now). I don't want to restrict it atm. Confused as if it will be good to have a standard style. 

The plugin-writing-doc needs to be updated. 

I will be committing the patch once I do some testing and cleanup.
Comment 2 Srinivasa Ragavan 2007-07-26 08:54:03 UTC 
Sankar, this fine. You break abi, but in evolution. So not a problem. But remove debug statements and make them with d(x). And avoid hard coding '1' for response.

Also remove your style of warnings on the console and make them meaningful. 

If you feel, you can do it for a few plugins directly and commit it with the patch.
Comment 3 Sankar P 2007-07-26 09:05:08 UTC 
It was just a temporary patch as jony wanted to try. Before committing I will remove all hard-coded values and debug statements.
Comment 4 Sankar P 2007-07-26 15:13:02 UTC 
Anybody who wants to write a plugin with configure support just have to implement e_plugin_lib_configure function.
Comment 5 Sankar P 2007-07-26 15:16:00 UTC 
Created attachment 92466 [details] [review]
Fix