GNOME Bugzilla – Bug 457533
Show both elapsed and remaining track time (PATCH)
Last modified: 2018-05-24 12:42:49 UTC
The attached patch formats the time string in rb_make_elapsed_time_string() in rb-util.c differently, so that the shell and the tray popup show the elapsed and remaining track time. However, this renders the last argument of the function, gboolean show_remaining, unused. Is this function part of a frozen API? Is it acceptable to simply remove this argument?
Created attachment 91879 [details] [review] Patch to lib/rb-util.c
Created attachment 93652 [details] [review] Patch to rb-util.c and the other modules using the patched function This patch allows to show elapsed, remaining time or both. A new gconf key was necessary to choose between these three possibilities.
I would really appreciate some kind of statement from a developer about this feature. Does it have a chance to get accepted upstream or not? If not, what do I have to improve?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/405.