After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 456308 - make the command entries insensitive
make the command entries insensitive
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-12 17:07 UTC by Matthias Clasen
Modified: 2007-07-12 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (12.28 KB, patch)
2007-07-12 17:11 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2007-07-12 17:07:02 UTC 
Instead of just !editable, when the command is not custom. 
As things are now, the entry strongly says "edit me" visually,
but then frustrates the user by refusing to be edited.
Comment 1 Matthias Clasen 2007-07-12 17:11:54 UTC 
Created attachment 91687 [details] [review]
the patch
Comment 2 Jens Granseuer 2007-07-12 17:26:25 UTC 
Thanks, please commit.
Comment 3 Matthias Clasen 2007-07-12 17:34:54 UTC 
Thanks, committed.

2007-07-12  Matthias Clasen  <mclasen@redhat.com>

        * gnome-default-applications-properties.glade:
        * gnome-da-capplet.c: Change the custom command entries to be
        insensitive, instead of noneditable, unless we are a custom
        command.  (#456308)
Comment 4 Luca Cavalli 2007-07-12 19:50:59 UTC 
Indeed this was the original behaviour, but then Christian Persch commented on bug #327749 recommending to make entries just disabled. I also replayed that the user would probably get a bit confused :)
Comment 5 Jens Granseuer 2007-07-12 21:02:55 UTC 
With Matthias' patch the entries are "just disabled". Before, they were only set to insensitive, which as you pointed out in the other bug, can be confusing. I don't see Christian asking for that there, though.