GNOME Bugzilla – Bug 456017
skip unneeded colorspace conversions
Last modified: 2007-07-29 10:52:08 UTC
As outlined in bug #78265, the lcms plug-in is currently not capable of detecting if the source and destination profiles are the same and queries the user for an unneeded colorspace conversion even if the image that is being opened does already have the RGB workspace profile. I am opening this bug report to move this discussion out of bug #78265 which is meant to deal with ICC profile support more generally.
Created attachment 91649 [details] [review] patch to identify identical profiles using MD5 checksums This patch follows the approach outlined by Alastair M. Robinson in bug #78265.
I have committed this with some other changes. Closing as FIXED for now. If it turns out not to work reliably, we will have to reopen this bug and find a better solution. 2007-07-11 Sven Neumann <sven@gimp.org> * plug-ins/common/lcms.c: clarify which procedures work with RGB profiles and which accept profiles for other colorspaces. Calculate MD5 checksums of the profile data excluding the header and skip attempts to convert between identical profiles (bug #456017).
At present the lcms plug-in does not create an md5 digest for the destination profile if it is loaded from disk (i.e. not built-in) so if any file profile is used as the working profile the convert dialog will always be displayed even if the profile is the same.
This should be fixed now: 2007-07-29 Sven Neumann <sven@gimp.org> * plug-ins/common/lcms.c: also calculate the checksum when loading the RGB profile from disk (bug #456017).