After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 455838 - Remove gnome-bluetooth dependency
Remove gnome-bluetooth dependency
Status: RESOLVED FIXED
Product: gnome-phone-manager
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: none
none
: 536239 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-07-11 10:02 UTC by Bastien Nocera
Modified: 2009-02-26 10:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
move to cut-n-paste (86.72 KB, patch)
2008-04-20 20:18 UTC, Baptiste Mille-Mathias
none Details | Review
patch to move to cut-n-paste and with removal of files in src/ (167.57 KB, patch)
2008-04-27 16:44 UTC, Baptiste Mille-Mathias
committed Details | Review

Description Bastien Nocera 2007-07-11 10:02:40 UTC
This might need to wait for a bluez-gnome provided widget.
Comment 1 Bastien Nocera 2007-11-17 03:34:29 UTC
Anyone fancying some cut'n'paste?
http://www.hadess.net/2007/11/gnome-bluetooth-kill-kill.html

1) Move the current cut'n'pasted code to cut-n-paste/ at the root of the project
2) Copy the necessary files from bluez-gnome, and update the Makefile.am to copy those files when running "make regenerate-built-sources"
3) Update configure.in to depend on dbus-glib rather than gnome-bluetooth
4) Update the PhonemgrChooserButton to use the new widget, and D-Bus instead of libbtctl

I'd take patches for any of the first items.
Comment 2 Baptiste Mille-Mathias 2008-04-20 20:18:06 UTC
Created attachment 109597 [details] [review]
move to cut-n-paste

This is a first try,

all the greetings go to Fred Peters, which gave all indications needed.
Comment 3 Baptiste Mille-Mathias 2008-04-27 16:44:31 UTC
Created attachment 109996 [details] [review]
patch to move to cut-n-paste and with removal of files in src/
Comment 4 Bastien Nocera 2008-06-13 05:19:05 UTC
I guess you can update this patch and commit it.

This solves 1), 2) isn't needed. Which leaves 3) and 4) :)
Comment 5 Baptiste Mille-Mathias 2008-06-16 20:32:43 UTC
Patch for task 1 commited

        * Makefile.am,
        configure.in,
        cut-n-paste/Makefile.am,
        cut-n-paste/update-from-egg.sh,
        cut-n-paste/e-contact-entry/e-contact-entry.c,
        cut-n-paste/e-contact-entry/e-contact-entry.h,
        cut-n-paste/e-contact-entry/econtactentry-marshal.list,
        cut-n-paste/e-contact-entry/Makefile.am,
        cut-n-paste/gconf-bridge/gconf-bridge.c,
        cut-n-paste/gconf-bridge/gconf-bridge.h,
        cut-n-paste/gconf-bridge/Makefile.am,
        src/e-contact-entry.c,
        src/e-contact-entry.h,
        src/econtactentry-marshal.list,
        src/gconf-bridge.c,
        src/gconf-bridge.h,
        src/Makefile.am: move cut'n pasted code to cut-n-paste/ to prepare
        gnome-bluetooth dependency removal (step 1 of #455838)
Comment 6 Bastien Nocera 2009-02-26 10:23:56 UTC
*** Bug 536239 has been marked as a duplicate of this bug. ***
Comment 7 Bastien Nocera 2009-02-26 10:26:19 UTC
Fixed in SVN, we use the new Bluetooth device chooser button from gnome-bluetooth now.

2009-02-26  Bastien Nocera  <hadess@hadess.net>

        * src/phonemgr-chooser-button.c:
        * src/phonemgr-chooser-button.h: Remove

        * configure.in:
        * data/phonemgr.glade:
        * src/Makefile.am:
        * src/app.h:
        * src/ui.c (chooser_created), (bluetooth_chooser_button_create),
        (set_dependent_widget): Remove use of the old gnome-bluetooth,
        and require the new one, which has its own Bluetooth device
        chooser button (Closes: #455838)