GNOME Bugzilla – Bug 453979
Use icon theme wherever possible
Last modified: 2007-07-05 15:28:44 UTC
The following patch converts Ekiga to using the icon theme for many of its icons before falling back to its inline icons. I was also somewhat aggressive about deleting icons that weren't used anymore. This patch builds on the work in bug #433275 and includes the patch there. It uses gtk_icon_theme_add_builtin_icon() to register the inline pngs as backups for the icon theme. One possibly controversial change is the emoticons. Unlike the other icons, these will not have backups. This is because I felt that mixing non-themed with themed emoticons would be very visually jarring and emoticons have a very reasonable fallback of just printing the smiley text. This may mean that in Windows, if the user doesn't have an installed gtk icon theme (I know it's possible, but I'm not really sure how that works in Windows), they won't have graphical smilies. Also, the icon naming specification [1] has different smiley coverage than Ekiga has had historically. It especially lacks the various dead faces and faces with noses. I don't know how attached you are to those. But the plus side are very pretty, themed smilies. I moved several pixmaps to better organize them, facilitate adding different sizes in the future, and facilitate updating the backup images from an existing icon theme. I also deleted a bunch of pixmaps. So rather than list all the changes (though you can see what they were in pixmaps/Makefile.am) for you to commit, I'd just as soon commit this myself, as I have the changes in my tree. But I can give you a list of what to do if you'd prefer. Not all icons were moved to icon theme. Some of them didn't have appropriate analogs or were part of a set in which not all of them did (local/remote contact, some of the status icons). [1] http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
Created attachment 91257 [details] [review] Proposed patch
I would have rather seen it in the other bug report, since it's the same thing. It will have the advantage that Luis Menina will be able to comment on this! *** This bug has been marked as a duplicate of 433275 ***