GNOME Bugzilla – Bug 453544
buttons "do not mark as read" and "mark as read" switched actions
Last modified: 2013-09-13 00:55:57 UTC
Please describe the problem: On Search Folders/Unmatched: right-click and select "mark messages are read". You are shown a pane with two buttons: "Do not Mark as Read" and "Mark as Read". If you select "Do not Mark as Read", all email is marked as read. If you select "Mark as Read" nothing is changed. The actions are reversed. Steps to reproduce: 1. right-click and select "Mark Messages as Read" on Search Folders/Unmatched 2. On the resulting pane, select "Mark as Read" 3. Actual results: No unmatched email is marked as read Expected results: Any unmatched email not yet read should be marked read Does this happen every time? yes. Other information: Ubuntu original bug: https://bugs.launchpad.net/ubuntu/+source/evolution/+bug/105392
well, in fact, shouldn't "Do not Mark as Read" be called "Cancel"? After all, we get to this panel by selecting "Mark Messages as Read"... but I guess this will be another bug, not really this one.
No, I stand corrected from my own mistake. This is done in plugins/mark-all-read/mark-all-read.c. There are two issues (at least) that I can see: 1. the dialog is misleading: "Do not Mark all Read" actually means "mark all read only on current folder"; "Mark all Read" means "mark all read on this folder and subfolders". 2. The behaviour is inconsistent: if you select "Do not...", then the current folder is summarily marked, independent of its type. If you select "Do mark...", then the subfolders are navigated, but emails are only marked if the (sub)folder is *NOT* a Virtual folder.
Created attachment 91493 [details] [review] make action text in dialog more coherent, take out test on vfolder I have changed the text in the "mark as read"dialog to a more correct text (mark on current folder only, on current folder and subfolders) as opposed to the original (do not mark as read, mark as read). I also took out the check on vfolder when navigating thru the folder list: this test is not performed on current-folder operations only. **I do *not* know if this is correct or not (taking out the vfolder test)**. I would really appreciate feedback on this.
The patch looks fine, apart from the vfolder stuff :). You shouldn't take that off.
Created attachment 91544 [details] [review] re-worked patch -- maintain test on vfolder Thank you.
Please commit to head.
Commited to head. Please announce to the gnome-i18n list about the string change.