GNOME Bugzilla – Bug 452472
[patch] have hipo use TreeModelFilter instead of plain search
Last modified: 2007-10-12 02:07:22 UTC
Attached patch does what subject says. However it's kind of ugly hacked, just wanted to give myself the feeling of it-was-worth-learning-to-use-gtk-tree-model, so it's attached.
Created attachment 90917 [details] [review] Uses TreeModelFilter in hipo As a base or reference for other patches, clever minds will spot the monodoc stolen code.
I like it, just a couple of things, for example if you search for "Monodoc" and your file is tagged as "monodoc" no results are found, this is really easy to fix, just add a ToLower or ToUpper (as you wish) in the SearchFilterFunc. The other issue is if you change to a playlist and do the search in there, you get the results based in the other model (tracks one) instead of the playlist one. I think that is a good option to disable the search while you're editing a playlist, it doesnt make too much sense to me having a search in there, you know is more important a search in the tracks view where you have like thousand of songs and not in a playlist where you usually have like 10 or 20 songs. I'm subscribing Felipe in case he want to say something about it, cause he's working in a hot search UI.
Created attachment 96892 [details] [review] Second version Took the case in consideration when searching. Made searching work in playlists. I agree about the hack nature of this patch, but the code in hipo isn't really a model of cleanliness to begin with. This patch didn't crash for me but I feel it should be tested again, it has the potential to break everything seriously.
Created attachment 96947 [details] [review] third patch (almost identical to second) It works for me, but with some issues, for instance, if I search with a term using upper-case, only shows matches within "title" tag.
committed to trunk, thanks.