GNOME Bugzilla – Bug 451925
gnome-nettool shows the link speed as not available under devices option
Last modified: 2008-12-04 02:01:27 UTC
Description: gnome-nettool shows the link speed as not available under devices option. Steps to reproduce: On a linux system 1. Install gnome-nettool rpm 2. Ensure that network card and corresponding driver are installed and is connected to a network. Configure the interface. 3. In the Appplications tab on the top left corner of the screen select System tools -> network tools 4. Select an interface that is functioning. 5. Observe the link speed field. The link speed is shown as Not Available . How reproducible: always.
Created attachment 90808 [details] [review] Changes made to mii.h and util-mii.c. Patch for review.
Request you to review the patch.
Any updates on this one ?
May you give some more information about the Linux distribution are you using? I'm not able to reproduce the error reported (Ubuntu/Debian). Anyway, If it is not possible to get the information, answering 'Not available' is the anwser pretented to be given: src/info.c:566 #ifdef __linux__ } else { if (data.has_data) { gtk_label_set_text (GTK_LABEL (info->link_speed), data.media); } else { gtk_label_set_text (GTK_LABEL (info->link_speed), NOT_AVAILABLE); } info_setup_configure_button (info, TRUE); #endif }
Distribution Used: Red Hat Enterprise Linux Server release 5 kernel version : 2.6.18-8.el5 Gnome nettool version : Version : 2.16.0 Release : 1.fc6 Gnome desktop version: Version : 2.16.0 Release : 1.fc6
Created attachment 95123 [details] Screen shot attached,
Comment on attachment 90808 [details] [review] Changes made to mii.h and util-mii.c. I don't get the idea why are you filling data.has_data when the ifname is not 'lo'. How is suppossed to fix the bug?
(In reply to comment #7) > (From update of attachment 90808 [details] [review] [edit]) > I don't get the idea why are you filling data.has_data when the ifname is not > 'lo'. I am filling the data.has_data when ifname is equal to "lo". ( if ( !strcmp (ifname, "lo" )). Sinse "lo" is a not a real device i thought ioctl should not be issued on it. > How is suppossed to fix the bug? The #include <linux/sockios.h> in mii.h ( attachment 90808 [details] [review]) provides the correct values for SIOCGMIIPHY which was earlier defined as SIOCDEVPRIVATE which the driver did not implement. This i think fixes the problem. Else the driver would return EOPNOTSUPP and ethernet device would be considered as a wireless device. ( In util-mii.c pls look under "get vitals from the interface". )
Please, test trunk. I ommited the strcmp part. I don't see any value added. Thanks.
Tested the trunk with the gnome-nettool source version 2.20.0 and it works fine. Thanks.
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find. *** This bug has been marked as a duplicate of 387198 ***