GNOME Bugzilla – Bug 451585
Dialog size and metatheme tab
Last modified: 2007-07-25 22:10:14 UTC
Right now the metatheme tab shows a horizontal scrollbar, even if there is enough (?) free space on either side (24 px in the case of clearlooks theme). If other themes are selected, the spacing changes and for Crux or the a11y themes, only 2 theme previews are shown in a row. What I would like to see: a) prevent changes in spacing or just make the dialog bigger, to allow even the "biggest" theme to fit 3 themes in a row. b) center the theme previews to always have the same space on the left and right of the outer previews. This was not a problem in the old dialog. I really like the new one but this make it feel less professional.
Created attachment 90747 [details] Screenshot This should make clear what I was talking about
I do see the unnecessary horizontal scollbar (not sure if it can be fixed, though, since setting scrollbar policy to NEVER causes those resizing issues; might just be a gtk bug), but I don't have the problems with resizing previews and not being able to fit 3 thumbnails with the Crux theme (gtk 2.11.4 here).
Ok, I actually managed to fix the scrollbar issue. Still can't reproduce the spacing changing, and I don't think b) is actually possible with GtkIconView.
I can confirm the spacing problem, but didn't find the source of the problem yet.
I am proud to announce the source of the spacing problem! It is actually not a problem in the GtkIconView spacing (i measured those, they stay identical), but in the different scrollbar widths; the larger scrollbar of the Crux theme takes up just enough space that three themes don't fit in a row anymore. Changing the following line from Crux' gtkrc: GtkRange::trough_border = 1 to: GtkRange::trough_border = 0 resolves the problem. One solution would be to make the icon view 1 or 2 pixel wider, though this would be very Crux-specific; High Contrast Inverse, for instance, makes the scrollbar even wider. But I think it would be acceptable to make the window so wide by default that all standard themes don't have the spacing issue anymore.
A fixed width request is not a solution. It might fix some case, but it will probably break just as many others, since the dialog width (and as a result the size of the icon view) depends on several factors, such as fonts and the length of the (localized) strings. I believe our best option atm is to wait for GtkIconView to get an "even spacing" option (or maybe to request that...).
This is now a duplicate of bug 459369, which depends on bug 460044 for the even spacing option. *** This bug has been marked as a duplicate of 459369 ***