After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450904 - Use "emblem-downloads" icon
Use "emblem-downloads" icon
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
git master
Other All
: Normal normal
: gnome-2-20
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 348350
 
 
Reported: 2007-06-25 13:39 UTC by Luca Ferretti
Modified: 2007-09-12 22:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Luca Ferretti 2007-06-25 13:39:45 UTC
Recently, the following changes happened on gnome-icon-theme package
  * emblem-download icon is finally available
  * document-save(-as) icon is using the same appearance of Ephy download icon

IMHO we should
  A. copy emblem-download images from g-i-t to epiphany, or
  B. directly use "emblem-download" icon in code, dropping custom "download"

Comments?
Comment 1 Christian Persch 2007-07-09 16:32:11 UTC
I'll take option B :) (assuming the version of g-i-t that has that icon will be in gnome 2.20)
Comment 2 Luca Ferretti 2007-07-10 02:44:35 UTC
Changes to code committed. New STOCK_DOWNLOAD defined and adopted, using "emblem-download".

If it's OK, I'll remove custom icon from sources.

PS you need g-i-t svn to show emblems at 16x16 pixels (icons available, but directory was missing in index.theme)
Comment 3 Christian Persch 2007-07-10 09:12:04 UTC
Sure, remove the obsolete icon.
Comment 4 Christian Persch 2007-09-10 19:53:03 UTC
Anything left to do here?
Comment 5 Luca Ferretti 2007-09-12 09:11:48 UTC
It seems I forgot to close it after commit, sorry.

   2007-07-10  Luca Ferretti  <elle.uca@libero.it>

        * data/icons/16x16/actions/Makefile.am:
        * data/icons/22x22/actions/Makefile.am:
        * data/icons/24x24/actions/Makefile.am:
        * data/icons/32x32/actions/Makefile.am:
        * data/icons/scalable/actions/Makefile.am:
        * data/icons/*/action/download.*:

        Kill old "download" icon. Fix bug 450904.


Closed as fixed.
Comment 6 Lapo Calamandrei 2007-09-12 22:19:31 UTC
ehm... sorry to comment on a closed bug, but are there any particular reason not to use just save-as there? The meaning is exactly that, save some stuff locally wihout asking questions.