After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450338 - Make gtk-doc.m4 fail when needed gtk-doc is not installed
Make gtk-doc.m4 fail when needed gtk-doc is not installed
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: 1.9
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks: 323938
 
 
Reported: 2007-06-23 12:22 UTC by Petteri Räty
Modified: 2007-09-23 14:22 UTC
See Also:
GNOME target: 2.20.x
GNOME version: ---

Attachments
gtk-doc.m4.patch (1.50 KB, patch)
2007-06-23 12:23 UTC, Petteri Räty 		committed Details | Review

Description Petteri Räty 2007-06-23 12:22:27 UTC 
I will a patch that does the following things:
1. Uses PKG_* m4 macros to simplify code
2. Makes configure exit when required gtk-doc is not installed. Without this make would just fail on some missing program with --enable-gtk-doc
3. Fixes bug 323938
Comment 1 Petteri Räty 2007-06-23 12:23:01 UTC 
Created attachment 90515 [details] [review]
gtk-doc.m4.patch
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2007-07-11 07:18:28 UTC 
shouldn't that part stay? We cannot assume that AC_PATH_PROG has been called before GTK_DOC_CHECK.

   if test x$enable_gtk_doc = xyes; then
    if test -z "$PKG_CONFIG"; then
      AC_PATH_PROG([PKG_CONFIG], [pkg-config], [no])
    fi
    ...
Comment 3 Petteri Räty 2007-07-11 09:17:32 UTC 
(In reply to comment #2)
> shouldn't that part stay? We cannot assume that AC_PATH_PROG has been called
> before GTK_DOC_CHECK.
> 
>    if test x$enable_gtk_doc = xyes; then
>     if test -z "$PKG_CONFIG"; then
>       AC_PATH_PROG([PKG_CONFIG], [pkg-config], [no])
>     fi
>     ...
> 

That's all handled by the pkg-config macros.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2007-07-12 08:06:41 UTC 
yes, you are right. I had a look at pkg.m4. +1 from my side to include this.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2007-07-16 15:20:42 UTC 
2007-07-16  Stefan Kost  <ensonic@users.sf.net>

	Patch by: Petteri Räty <betelgeuse@gentoo.org>

	* gtk-doc.m4:
	Make gtk-doc.m4 fail when needed gtk-doc is not installed and notify
	user. Fixes #323938 and #450338.