After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 448330 - Use glib API for xdg-user-dirs.
Use glib API for xdg-user-dirs.
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-16 21:53 UTC by Martin Ejdestig
Modified: 2007-09-05 03:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.71 KB, patch)
2007-06-30 02:37 UTC, Jonathan Matthew 		none Details | Review
better patch (2.43 KB, patch)
2007-07-01 02:08 UTC, Jonathan Matthew 		committed Details | Review

Description Martin Ejdestig 2007-06-16 21:53:38 UTC 
If the user hasn't manually set Library Location, use xdg-user-dirs to locate the user's music folder.

(g_get_user_special_dir() is in glib 2.13.X and 2.14 should be released soon... I think.)
Comment 1 Martin Ejdestig 2007-06-16 22:04:07 UTC 
Ok, just noticed that xdg-user-dirs support is in SVN. Changing this bug to be about using the glib API instead.

Sorry for the spam.
Comment 2 Jonathan Matthew 2007-06-30 02:37:46 UTC 
Created attachment 90911 [details] [review]
patch

This also fixes the other glib function checks to use the glib library pkg-config points to, rather than the one in /usr/lib/, which caused false negatives for jhbuild-like setups.
Comment 3 Jonathan Matthew 2007-07-01 02:08:53 UTC 
Created attachment 90952 [details] [review]
better patch

better way of fixing configure.ac, fix a warning in lib/rb-file-helpers.c
Comment 4 James "Doc" Livingston 2007-07-05 10:48:48 UTC 
Looks good to me
Comment 5 James "Doc" Livingston 2007-08-05 05:08:11 UTC 
Did this patch actually get committed? I can't see it in svn.
Comment 6 Jonathan Matthew 2007-09-05 03:46:30 UTC 
It didn't, so I've committed it now.