Created attachment 90617 [details] [review]
proposed patch

We're getting the events now.  However, because Gecko prefers a range of 0-1 rather than 0-100, we're failing to announce updates because int(value.currentValue) will always be 0.  It seems we should compare and store the percentValue instead.

Also, according to what was decided in bug #438333:

          - When progress bar is at 100%, we should present it, regardless
            of the interval.

Doesn't this mean we need to do the check for 100% outside of the block beginning with:

                 if (currentTime - lastProgressBarTime) > \
                           settings.progressBarUpdateInterval:

?

Anyhoo, I made the above adjustments, along with some tweaks to Gecko.py and things seem to be working more or less as expected.  Note that we do not seem to get an event in Gecko.py when the progress bar hits 100% so that is not getting spoken.  I'll ask for that.

Rich, do you see/foresee any problems with the changes I made to handleProgressBarUpdate()?  Thanks!

Your changes look good to me. I don't foresee any problems.
I suggest committing them, and then get Mike to test. Thanks for
doing this.

Thanks Rich!  Patch committed.  Mike please test.

Nice fix.  thanks much

Thank you.  Closing as FIXED.