After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447467 - Configure a Salut account is too complicated
Configure a Salut account is too complicated
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2007-06-14 10:21 UTC by Guillaume Desmottes
Modified: 2007-08-23 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed implementation (31.35 KB, patch)
2007-08-22 12:18 UTC, Cosimo Cecchi
none Details | Review
forgot to mark a string for translation (31.35 KB, patch)
2007-08-22 15:35 UTC, Cosimo Cecchi
committed Details | Review

Description Guillaume Desmottes 2007-06-14 10:21:50 UTC
Salut is about "zero conf" so, enable it shouldn't be more complicated than checking a box.
Comment 1 Guillaume Desmottes 2007-07-21 15:25:28 UTC
A good solution could be to automatically add a salut account the first time empathy is launched with Salut installed.
So most of lambda users who will have salut installed by default with their distribution will automagically see contacts on their local LAN.
Comment 2 Vincent Untz 2007-07-22 00:44:18 UTC
Nod. It's probably useful to let people be able to enable/disable it.
Comment 3 Cosimo Cecchi 2007-08-20 11:15:19 UTC
I do not see anymore Salut configure options in SVN trunk now. Maybe Guillaume's suggestion was implemented?
Comment 4 Xavier Claessens 2007-08-20 11:41:15 UTC
Nothing changed, you still have to add a Salut account and configure it using the poor generic UI. If you don't see it maybe you don't have telepathy-salut installed ?
Comment 5 Xavier Claessens 2007-08-20 20:39:13 UTC
I think the good solution here is to create a salut account first time Empathy is started and telepathy-salut is installed taking information from about-me.

So it would looks like that in empathy.c:
if (gconf_key("salut-account-created") == FALSE && telepathy-salut installed)
{
  set_gconf_key("salut-account-created", true);
  create_salut_account_using_about_me_info();
}

Like that the user can still disable/remove the account if he wants and change account information in the account dialog like others

We also need a specialised UI for salut.

If someone is interested by working on that I would be really happy, that's not too difficult and that can make a big difference for users!
Comment 6 Vincent Untz 2007-08-20 20:41:35 UTC
Xavier: sounds nice. I'd suggest auto-updating the info from about-me, instead of letting the user change the data in empathy. If the user wants to change information, then just launch gnome-about-me.
Comment 7 Xavier Claessens 2007-08-20 21:11:14 UTC
about-me comes from EDS I think? Intergration will be done later, we have tones of things to do to have a good eds support.

In general we should take information from about-me for all accounts and keep that in sync but I think that should/could be done by an external application like eds-sync.

For now I think we can just create the salut account with default values from about-me and don't care too much about keeping information sync, that needs lots more work.
Comment 8 Cosimo Cecchi 2007-08-22 12:18:36 UTC
Created attachment 94103 [details] [review]
proposed implementation

This patch implements the requested behaviour, and adds a specialised UI for Salut.
Comment 9 Cosimo Cecchi 2007-08-22 15:35:39 UTC
Created attachment 94126 [details] [review]
forgot to mark a string for translation

Forgot to mark "Local Network" as translatable.
Comment 10 Xavier Claessens 2007-08-23 10:28:58 UTC
Thanks for the patch, I cleaned it a bit.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.