After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447363 - Needs "press to play" overlay
Needs "press to play" overlay
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on:
Blocks:
 
 
Reported: 2007-06-14 00:18 UTC by Bastien Nocera
Modified: 2007-06-20 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
click-to-play.png (46.16 KB, image/png)
2007-06-14 16:23 UTC, Bastien Nocera
  Details
totem-click-to-play.patch (3.58 KB, patch)
2007-06-14 16:24 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2007-06-14 00:18:07 UTC
When autostart is off, not seeing the video starting can throw you off. We should overlay a play button on top of the image when autostart is off.
Comment 1 Bastien Nocera 2007-06-14 00:23:24 UTC
We need to change the totem_embedded_set_logo_by_name() call in totem_embedded_construct().
Comment 2 Bastien Nocera 2007-06-14 16:23:44 UTC
Created attachment 89959 [details]
click-to-play.png

What it looks like now.
Comment 3 Bastien Nocera 2007-06-14 16:24:17 UTC
Created attachment 89960 [details] [review]
totem-click-to-play.patch

Horribly crappy patch. I don't know what it should look like.
Comment 4 Bryan W Clark 2007-06-15 15:02:35 UTC
If you just need to get people to press the play button perhaps you could use the same kind of button glow effect on the play button as the task bar does for windows that are trying to get attention.  it will focus the action on the area you'd like clicked.

I'm trying to build totem trunk now so I can see this patch, but it's taking a while.
Comment 5 Bastien Nocera 2007-06-15 15:08:59 UTC
(In reply to comment #4)
> If you just need to get people to press the play button perhaps you could use
> the same kind of button glow effect on the play button as the task bar does for
> windows that are trying to get attention.  it will focus the action on the area
> you'd like clicked.
> 
> I'm trying to build totem trunk now so I can see this patch, but it's taking a
> while.

Don't worry about the patch, it's crass and horrible, just my attempts at making something pleasing to the eye in the video canvas area.

Throbbing the play button is a _great_ idea, which I'll work on implementing straight away. Thanks!
Comment 6 Bastien Nocera 2007-06-16 21:03:38 UTC
2007-06-16  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/Makefile.am:
        * browser-plugin/totem-glow-button.[ch]:
        Add a "glow button" that will glow like the tasklist with urgency hint
        * browser-plugin/totem-plugin-viewer.c: (totem_embedded_set_state),
        (totem_embedded_set_pp_state), (on_play_pause),
        (totem_embedded_construct), (totem_pp_create):
        * data/mozilla-viewer.glade: Make the play button glow when autostart
        is off so that users know that they need to click play to see something
        (Closes: #447363)
Comment 7 Christian Persch 2007-06-16 21:31:02 UTC
Shouldn't this respect the "gtk-enable-animations" settings? And also remove the timeout when unmapped ?
Comment 8 Bastien Nocera 2007-06-20 11:48:05 UTC
(In reply to comment #7)
> Shouldn't this respect the "gtk-enable-animations" settings? And also remove
> the timeout when unmapped ?

Good point. Both fixed, thanks.

2007-06-20  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totem-glow-button.c:
        (totem_glow_button_do_expose), (totem_glow_button_glow),
        (take_screenshot), (totem_glow_button_expose),
        (totem_glow_button_map), (totem_glow_button_unmap),
        (totem_glow_button_class_init), (totem_glow_button_init),
        (totem_glow_button_set_glow), (totem_glow_button_get_glow):
        * browser-plugin/totem-glow-button.h:
        When the animations are disabled, only draw the button in the highest
        glowing state and stop. Stop drawing anything when the button is unmapped.
        (comments on #447363)