GNOME Bugzilla – Bug 447363
Needs "press to play" overlay
Last modified: 2007-06-20 11:48:05 UTC
When autostart is off, not seeing the video starting can throw you off. We should overlay a play button on top of the image when autostart is off.
We need to change the totem_embedded_set_logo_by_name() call in totem_embedded_construct().
Created attachment 89959 [details] click-to-play.png What it looks like now.
Created attachment 89960 [details] [review] totem-click-to-play.patch Horribly crappy patch. I don't know what it should look like.
If you just need to get people to press the play button perhaps you could use the same kind of button glow effect on the play button as the task bar does for windows that are trying to get attention. it will focus the action on the area you'd like clicked. I'm trying to build totem trunk now so I can see this patch, but it's taking a while.
(In reply to comment #4) > If you just need to get people to press the play button perhaps you could use > the same kind of button glow effect on the play button as the task bar does for > windows that are trying to get attention. it will focus the action on the area > you'd like clicked. > > I'm trying to build totem trunk now so I can see this patch, but it's taking a > while. Don't worry about the patch, it's crass and horrible, just my attempts at making something pleasing to the eye in the video canvas area. Throbbing the play button is a _great_ idea, which I'll work on implementing straight away. Thanks!
2007-06-16 Bastien Nocera <hadess@hadess.net> * browser-plugin/Makefile.am: * browser-plugin/totem-glow-button.[ch]: Add a "glow button" that will glow like the tasklist with urgency hint * browser-plugin/totem-plugin-viewer.c: (totem_embedded_set_state), (totem_embedded_set_pp_state), (on_play_pause), (totem_embedded_construct), (totem_pp_create): * data/mozilla-viewer.glade: Make the play button glow when autostart is off so that users know that they need to click play to see something (Closes: #447363)
Shouldn't this respect the "gtk-enable-animations" settings? And also remove the timeout when unmapped ?
(In reply to comment #7) > Shouldn't this respect the "gtk-enable-animations" settings? And also remove > the timeout when unmapped ? Good point. Both fixed, thanks. 2007-06-20 Bastien Nocera <hadess@hadess.net> * browser-plugin/totem-glow-button.c: (totem_glow_button_do_expose), (totem_glow_button_glow), (take_screenshot), (totem_glow_button_expose), (totem_glow_button_map), (totem_glow_button_unmap), (totem_glow_button_class_init), (totem_glow_button_init), (totem_glow_button_set_glow), (totem_glow_button_get_glow): * browser-plugin/totem-glow-button.h: When the animations are disabled, only draw the button in the highest glowing state and stop. Stop drawing anything when the button is unmapped. (comments on #447363)