After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 447359 - GtkImContextMultipress mishandles control keys
GtkImContextMultipress mishandles control keys
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Input Methods
unspecified
Other All
: Normal normal
: ---
Assigned To: Hidetoshi Tajima
gtk-bugs
Depends on: 417446
Blocks:
 
 
Reported: 2007-06-13 23:44 UTC by Daniel Elstner
Modified: 2007-06-17 09:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to make the IM act on key press events (4.72 KB, patch)
2007-06-13 23:47 UTC, Daniel Elstner
accepted-commit_now Details | Review

Description Daniel Elstner 2007-06-13 23:44:32 UTC
This is a follow-up to bug #417446 in order to deal with the remaining TODOs in the multipress IM code.

> /* TODO: The delete key does not seem to be handled when we do this.
>  * danielk: Yes, that's normal and it's not the only one.  I'll get to
>  * that later. */

Delete and other control keys are mishandled because the text input widget handles them before the IM filter receives the corresponding key release event.  As it turns out the problem can be avoided by simply filtering key press events instead.  This is the more natural behavior anyway, and the special casing already in place for some control codes can be dropped, too.
Comment 1 Daniel Elstner 2007-06-13 23:47:37 UTC
Created attachment 89920 [details] [review]
Patch to make the IM act on key press events

Patch attached.  OK to commmit?
Comment 2 Matthias Clasen 2007-06-17 06:21:04 UTC
I haven't tried it, but looks ok.
Comment 3 Daniel Elstner 2007-06-17 09:50:04 UTC
Committed.