After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 446533 - vte_terminal_set_colors() docs outdated
vte_terminal_set_colors() docs outdated
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
: 337124 (view as bug list)
Depends on:
Blocks: vte1.0
 
 
Reported: 2007-06-11 21:38 UTC by Behdad Esfahbod
Modified: 2015-01-09 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (3.65 KB, patch)
2015-01-08 23:19 UTC, Egmont Koblinger
committed Details | Review

Description Behdad Esfahbod 2007-06-11 21:38:16 UTC
They don't talk about 256-color support.  The function entry should probably be changed to allow arbitrary palette sizes in, not sure.
Comment 1 Behdad Esfahbod 2010-04-08 15:09:35 UTC
Also from bug 337124:

Date: Mon, 3 Apr 2006 15:09:45 -0400
From: Enrico Tröger
To: behdad gnome org
Subject: VTE documentation update
Parts/Attachments:
   1 Shown    ~24 lines  Text
   2          198 bytes  Application
----------------------------------------

Hi Kjartan,

in the document
http://developer.gnome.org/doc/API/2.0/vte/vteterminal.html there is no
hint, that changing the fore- or background color takes only effect if
the VTE widget is already realized(I simply forced this by calling
gtk_widget_realize()). Perhabs you can add a note to the documentation.
I think this hint is very useful, I have spent about half an hour to
find it out. ;-)


best regards,
Enrico
Comment 2 Behdad Esfahbod 2010-04-08 15:09:44 UTC
*** Bug 337124 has been marked as a duplicate of this bug. ***
Comment 3 Egmont Koblinger 2015-01-03 15:05:40 UTC
It has changed a lot since then, but it's still buggy (not just the docs, there are problems with the code too).

At least the remains of the 24-color palette with dim colors (bug 735245) should be removed for good.

FYI: there are two methods with way too similar name, similar docs but different behavior:
_vte_terminal_set_colors()
vte_terminal_set_colors()
Comment 4 Egmont Koblinger 2015-01-08 23:19:19 UTC
Created attachment 294129 [details] [review]
Fix

I'm planning to submit this.

Strictly speaking this breaks backwards compatibility by refusing partial 6x6x6 colors cube or partial grayscale map, but I really hope noone was stupid enough to ever do this. It didn't work with 17..23 entries anyway, a leftover from the dim map days. And I don't think it makes sense to allow this.
Comment 5 Egmont Koblinger 2015-01-09 21:58:31 UTC
Fixed.