After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 445965 - Use GtkFileChooserButton to setup library location
Use GtkFileChooserButton to setup library location
Product: rhythmbox
Classification: Other
Component: general
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
aklapper[mnemonics] ghop[2007-14]
Depends on:
Reported: 2007-06-10 07:53 UTC by Luca Ferretti
Modified: 2018-05-24 12:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

The current layout (6.96 KB, image/png)
2007-06-10 08:03 UTC, Luca Ferretti
The desired (and required by HIG) layout (6.14 KB, image/png)
2007-06-10 08:05 UTC, Luca Ferretti
Fixes the access key (1.77 KB, patch)
2007-12-02 12:01 UTC, David Turner
committed Details | Review
patch for this bug (10.47 KB, patch)
2008-10-31 21:02 UTC, Maxim Ermilov
needs-work Details | Review

Description Luca Ferretti 2007-06-10 07:53:16 UTC
In preferences dialog, Rhythmbox is currently using a simple text entry plus a button to choose the library's directory.

The "right" widget here should be a GtkFileChooserButton[1] in select folder mode. The same widget is yet used in Podcast section to set up the download directory for podcasts.

Please also note that there is a GNOME HIG rules breakage here: the text entry (same will occur with GtkFileChooserButton, it's a drop down list[2]) should have a text label providing an access key. On current setup the label is missing and the access key is on section header (bolded text).

Comment 1 Luca Ferretti 2007-06-10 08:03:48 UTC
Created attachment 89681 [details]
The current layout
Comment 2 Luca Ferretti 2007-06-10 08:05:35 UTC
Created attachment 89682 [details]
The desired (and required by HIG) layout

Note 1: the spacing between GtkFileChooserButton and its label is 12 pixels as per

Note 2: used labels are just for draft purpose
Comment 3 James "Doc" Livingston 2007-06-16 07:26:17 UTC
We used to use GtkFileChooserButton but it had some issues, so we changed to the current entry + browse button.

GtkFileChooserButton can only point to a directory that "exists", which is bad if the library is on a partition that isn't mounted or a network share. If you open the preferences dialog while it isn't available, GtkFileChooserButton will change to point to your home directory. If you have "watch for new tracks" turned on, this will cause RB to start importing your home directory.

The access key definitely needs fixing though.
Comment 4 David Turner 2007-12-02 12:01:18 UTC
Created attachment 100040 [details] [review]
Fixes the access key

This patch should fix the access key issue, by creating a new label next to the text entry (with the text suggested in the screenshot) and pointing the mnemonic at the text box (And removing the mnemonic from the heading).
Comment 5 Jonathan Matthew 2008-06-08 14:28:00 UTC
I rearranged things a bit so the result looks more like the screenshot from comment 2 and committed it.  The main issue here (using a GtkFileChooserButton) remains open.
Comment 6 Maxim Ermilov 2008-10-31 21:02:27 UTC
Created attachment 121748 [details] [review]
patch for this bug
Comment 7 Jonathan Matthew 2008-10-31 22:00:52 UTC
How does this address the problems described in comment 3?
Comment 8 GNOME Infrastructure Team 2018-05-24 12:37:48 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: