GNOME Bugzilla – Bug 445965
Use GtkFileChooserButton to setup library location
Last modified: 2018-05-24 12:37:48 UTC
In preferences dialog, Rhythmbox is currently using a simple text entry plus a button to choose the library's directory.
The "right" widget here should be a GtkFileChooserButton in select folder mode. The same widget is yet used in Podcast section to set up the download directory for podcasts.
Please also note that there is a GNOME HIG rules breakage here: the text entry (same will occur with GtkFileChooserButton, it's a drop down list) should have a text label providing an access key. On current setup the label is missing and the access key is on section header (bolded text).
Created attachment 89681 [details]
The current layout
Created attachment 89682 [details]
The desired (and required by HIG) layout
Note 1: the spacing between GtkFileChooserButton and its label is 12 pixels as per http://developer.gnome.org/projects/gup/hig/2.0/design-text-labels.html
Note 2: used labels are just for draft purpose
We used to use GtkFileChooserButton but it had some issues, so we changed to the current entry + browse button.
GtkFileChooserButton can only point to a directory that "exists", which is bad if the library is on a partition that isn't mounted or a network share. If you open the preferences dialog while it isn't available, GtkFileChooserButton will change to point to your home directory. If you have "watch for new tracks" turned on, this will cause RB to start importing your home directory.
The access key definitely needs fixing though.
Created attachment 100040 [details] [review]
Fixes the access key
This patch should fix the access key issue, by creating a new label next to the text entry (with the text suggested in the screenshot) and pointing the mnemonic at the text box (And removing the mnemonic from the heading).
I rearranged things a bit so the result looks more like the screenshot from comment 2 and committed it. The main issue here (using a GtkFileChooserButton) remains open.
Created attachment 121748 [details] [review]
patch for this bug
How does this address the problems described in comment 3?
-- GitLab Migration Automatic Message --
This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/383.