GNOME Bugzilla – Bug 443337
[veriried] Orca should not use the alt text if it is empty to infer a link name
Last modified: 2008-07-22 19:27:43 UTC
1. go to www.michiganflyer.com and tab through the image links. You will not hear or see in braille any name for these links. The cause of this is that the alt text is set but it is empty.
Created attachment 89301 [details] [review] patch to hopefully solve the problem Mike please test.
Cool! this nicely fixes the michigan flyer problem. Earlier this morning I discovered that www.bankofamerica.com was exibiting the same problem of just saying link in a few places. Before your patch you could tab through this site and observe this problem in a few places. After your patch these links now say nothing.
Thanks Mike. Patch checked in. Moving this to pending.
(In reply to comment #2) > Cool! this nicely fixes the michigan flyer problem. Earlier this morning I > discovered that www.bankofamerica.com was exibiting the same problem of just > saying link in a few places. Before your patch you could tab through this site > and observe this problem in a few places. After your patch these links now say > nothing. Just to be sure -- is the "after your patch these links now say nothing" the desired behavior?
I had misunderstood Mike. Sorry about that. That said, I was just on the phone with him and he was pointing out the links that were not working for him. On my machine, without the patch, Orca says "link grayed" for them. With the patch, it speaks their names.... <shrugs> Taking this out of "pending".
Another data point: Occasionally on my system Orca does not say anything for one of the links in question. When this occurs it is due to a lack of a focus: event for that link (in those cases, we seem to only get a caret-moved event). And in those circumstances, without the patch or with the patch, Orca says nothing. Mike indicated that he'd send me a debug.out. It's about 10:30 PM now. Between an A.M. doctor's appointment and my actual job <smile> I will not have time to look at this again until some time tomorrow late afternoon/early evening -- i.e. post 2.19.3. Therefore, Mike, please let me know if you'd like me to reverse the patch for the release.
The bankofamerica problem seems to be un-related to this patch. We can look at that in another bug. I think this one is OK
Thanks Mike. As a related aside, I had mis-spoke (mis-typed) in comment #5. I hadn't reversed the patch in that case; I had commented out the relevant section of code. *That* is why Orca was only saying "link grayed." When I properly reversed the patch, there was no difference: Orca still spoke the text of the link **as long as we got a focus: event for it.** I filed a bug against Orca for the BofA problem: Bug #433791. I'll look at that tomorrow afternoon/evening. Putting this bug back to pending.
Sheesh I'm tired. Make that bug #443791.
Created attachment 89361 [details] [review] minor revision: Check for name first
With this latest patch "link greyed" is back on www.bankofamerica.com for me.
Sorry to be dense, Mike, but is this a good thing or a bad thing? By the way, I committed the patch so if you grabbed the latest from trunk and then applied the patch, you undid it. Please clarify what you're seeing and what you would like to see if these two things are different. :-) Thanks!
Last night it was speaking nothing. Today it is speaking link greyed. Neither is good but that's another bug. This has fixed the michiganflyer bug
Mike has verified this. Closing as FIXED.