GNOME Bugzilla – Bug 442625
Add a way to call the "Force Quit" dialogue
Last modified: 2015-03-24 13:01:06 UTC
Similarly to the run dialogue, we should have a way to call the panel's force quit dialogue from other apps. Changes needed in gnome-panel/panel-action-protocol.c
Created attachment 89467 [details] [review] gnome-panel-add-force-quit.patch Implement that.
Comment on attachment 89467 [details] [review] gnome-panel-add-force-quit.patch I guess this makes sense. Of course, I'd love to have a dbus service instead ;-) A few comments, though: >Index: gnome-panel/panel-action-protocol.c >=================================================================== >--- gnome-panel/panel-action-protocol.c (revision 10451) >+++ gnome-panel/panel-action-protocol.c (working copy) >@@ -42,6 +42,7 @@ > static Atom atom_gnome_panel_action = None; > static Atom atom_gnome_panel_action_main_menu = None; > static Atom atom_gnome_panel_action_run_dialog = None; >+static Atom atom_gnome_panel_action_kill_dialog = None; Could you also make us use GdkAtom (it also means not using XInternAtom)? It's not really a high priority, but I prefer to move things from X to GDK when possible ;-) >-panel_force_quit (GdkScreen *screen) >+panel_force_quit (GdkScreen *screen, guint time) Please make this (in the .c and .h files): panel_force_quit (GdkScreen *screen, guint time) Also, could you update doc/gnome-panel-action-protocol.txt ? Thanks! Out of curiosity, what's the use case for this?
(In reply to comment #2) > (From update of attachment 89467 [details] [review] [edit]) > I guess this makes sense. Of course, I'd love to have a dbus service instead > ;-) > > A few comments, though: > > >Index: gnome-panel/panel-action-protocol.c > >=================================================================== > >--- gnome-panel/panel-action-protocol.c (revision 10451) > >+++ gnome-panel/panel-action-protocol.c (working copy) > >@@ -42,6 +42,7 @@ > > static Atom atom_gnome_panel_action = None; > > static Atom atom_gnome_panel_action_main_menu = None; > > static Atom atom_gnome_panel_action_run_dialog = None; > >+static Atom atom_gnome_panel_action_kill_dialog = None; > > Could you also make us use GdkAtom (it also means not using XInternAtom)? It's > not really a high priority, but I prefer to move things from X to GDK when > possible ;-) Huh, I guess behind the scope of this bug. I filed 453394 about it. > >-panel_force_quit (GdkScreen *screen) > >+panel_force_quit (GdkScreen *screen, guint time) > > Please make this (in the .c and .h files): > > panel_force_quit (GdkScreen *screen, > guint time) And aligned like the other prototypes, I guess. Done. > Also, could you update doc/gnome-panel-action-protocol.txt ? > > Thanks! > > Out of curiosity, what's the use case for this? See blocker, to add a "force quit" keybindings. 2007-07-03 Bastien Nocera <hadess@hadess.net> * doc/gnome-panel-action-protocol.txt: Update the documentation for the action protocol, following the addition of _GNOME_PANEL_ACTION_KILL_DIALOG (Closes: #442625) 2007-07-03 Bastien Nocera <hadess@hadess.net> * panel-action-button.c: (panel_action_force_quit): * panel-action-protocol.c: (panel_action_protocol_kill_dialog), (panel_action_protocol_filter), (panel_action_protocol_init): * panel-force-quit.c: (panel_force_quit): * panel-force-quit.h: Add the _GNOME_PANEL_ACTION_KILL_DIALOG message to allow a keybinding for the force quit dialogue to be added (Closes: #442625)