After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 442378 - 0.11 ipod eject = crash
0.11 ipod eject = crash
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.11.x
Other Linux
: Normal critical
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 338564
 
 
Reported: 2007-05-30 17:46 UTC by Sebastien Bacher
Modified: 2007-06-02 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix attempt (1.07 KB, patch)
2007-05-30 22:40 UTC, Christophe Fergeau 		committed Details | Review

Description Sebastien Bacher 2007-05-30 17:46:49 UTC 
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/117724

"Binary package hint: rhythmbox

rhythmbox 0.11.0-0ubuntu1

when hitting the eject button rhythmbox crashes

gdb says:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1230506288 (LWP 16240)]
0xb7eaf04d in rb_source_delete_thyself () from /usr/lib/librhythmbox-core.so.0
(gdb)

nothing before regarding the crash
...
first you select the ipod in the left list, then click on the "eject
this device" button in the toolbar, near the visual effects one. The
same behavior if I use eject from right clicking on the ipod name.

I can eject the ipod through the drivemount applet and the desktop
without problems.
...

+ Trace 136856

Thread 1 (Thread -1230203184 (LWP 20154))

  • #0 rb_source_delete_thyself
    at rb-source.c line 1030
  • #1 impl_delete_thyself
    at rb-ipod-source.c line 1335
  • #2 rb_source_delete_thyself
    at rb-source.c line 1030
  • #3 rb_removable_media_manager_unmount_volume
    at rb-removable-media-manager.c line 466
  • #4 rb_removable_media_manager_cmd_eject_medium
    at rb-removable-media-manager.c line 548
  • #5 g_cclosure_marshal_VOID__VOID
    from /usr/lib/libgobject-2.0.so.0
  • #6 g_closure_invoke
    from /usr/lib/libgobject-2.0.so.0
  • #7 ??
    from /usr/lib/libgobject-2.0.so.0
  • #8 ??
  • #9 ?? 






Comment 1


Christophe Fergeau





          2007-05-30 22:40:57 UTC
        



Created attachment 89077 [details] [review]
Fix attempt

Hopefully this patch should fix that crash. The rb-source.c hunk adds a g_return_if_fail to make sure rb doesn't crash when rb_source_delete_thyself is called with a NULL param. The rb-ipod-source.c hunk is only worth testing if the reporter has smart playlists on his ipod, but if that's the case, that should fix the crash.
I haven't tested if that patch compiles, it may need a few adjustments ;)






Comment 2


Christophe Fergeau





          2007-05-31 08:41:33 UTC
        



(In reply to comment #1)
> Created an attachment (id=89077) [edit]
> Fix attempt
> 

Compile tested with svn trunk






Comment 3


Nicolò Chieffo





          2007-05-31 09:03:55 UTC
        



I don't understand why it need playlists to work..






Comment 4


Nicolò Chieffo





          2007-05-31 09:07:31 UTC
        



Maybe I understood now: I had a strange playlist with no title, the cause might be it, because now that I removed it the eject is ok, and now in rhythmbox I can see other playlists too! (before I couldn't)






Comment 5


Sebastien Bacher





          2007-05-31 09:33:08 UTC
        



the crash happens after creating a smart playlist with gtkpod, the patch makes it work correctly






Comment 6


Nicolò Chieffo





          2007-05-31 09:37:02 UTC
        



To tell the truth I have never created such playlist I've just installed gtkpod to remove every playlist...






Comment 7


James "Doc" Livingston





          2007-06-02 02:41:47 UTC
        



Committed to svn thanks.






Comment 8


Nicolò Chieffo





          2007-06-02 10:12:13 UTC
        



Ok it works now, it must have been itunes! Thank you very much