GNOME Bugzilla – Bug 441901
Crash on searching in plugin list
Last modified: 2007-06-04 16:48:17 UTC
If you open the plugins dialog, and press a key for which there isn't a plugin starting with that letter, Totem will crash while trying to get the icon for a non-existent plugin. A patch is forthcoming. This also affects Rhythmbox (and anything else which uses this plugin code).
Created attachment 88962 [details] [review] Fixes crash Fixes crash (we were missing a NULL check).
You would probably want to make the whole right-portion of the dialogue unsensitive, or change the selection-mode of the treeview so that the plugins can't be unselected (and the selection empty). gtk_tree_selection_set_mode() with GTK_SELECTION_BROWSE is probably the easiest way to fix this.
Created attachment 88976 [details] [review] Additionally sets to browse mode This patch fixes the crash and sets the tree view to browse mode.
Does just setting to browse mode fix the crash? If so, I'd rather avoid the "if NULL return" altogether.
Even with browse mode, the search box comes up when you press a letter, and it calls cursor_changed_cb with a NULL plugin. Most of the other functions in the file check for NULL, so either there's something deeply wrong, or this change is fine (as far as I can tell, anyway).
Please commit to trunk.
2007-06-04 Philip Withnall <pwithnall@svn.gnome.org> * src/plugins/totem-plugin-manager.c: (cursor_changed_cb), (plugin_manager_construct_tree): Prevent crash when using find on the plugins list (Closes: #441901)