After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 441014 - Compilation warning in evolution's widgets folder
Compilation warning in evolution's widgets folder
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.12.x
Other All
: Normal trivial
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
evolution[codecleanup]
Depends on:
Blocks: 437579
 
 
Reported: 2007-05-24 18:38 UTC by Gilles Dartiguelongue
Modified: 2013-09-13 00:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18


Attachments
evolution-widgets-e-tz-dialog.patch (590 bytes, patch)
2007-05-24 18:41 UTC, Gilles Dartiguelongue
committed Details | Review
evolution-widgets-menus.patch (5.75 KB, patch)
2007-05-24 19:31 UTC, Gilles Dartiguelongue
committed Details | Review
evolution-widgets-misc.patch (12.98 KB, patch)
2007-05-24 19:42 UTC, Gilles Dartiguelongue
none Details | Review
evolution-widgets-misc.patch (11.24 KB, patch)
2007-05-24 19:50 UTC, Gilles Dartiguelongue
none Details | Review
evolution-widgets-misc.patch (11.77 KB, patch)
2007-05-24 19:54 UTC, Gilles Dartiguelongue
committed Details | Review
evolution-widgets-table.patch (31.26 KB, patch)
2007-05-24 20:11 UTC, Gilles Dartiguelongue
committed Details | Review
evolution-widgets-ChangeLog.patch (682 bytes, patch)
2007-05-24 20:22 UTC, Gilles Dartiguelongue
committed Details | Review

Description Gilles Dartiguelongue 2007-05-24 18:38:02 UTC
to follow, a serie of patchs to fix most compilation warnings in evolution/widgets
Comment 1 Gilles Dartiguelongue 2007-05-24 18:41:23 UTC
Created attachment 88754 [details] [review]
evolution-widgets-e-tz-dialog.patch

I'll go subfolder by subfolder this time, unless you prefer to read 1400 lines of diff in a row.

This patch is really simple also there is a need to double check the #if 0 out function for it's really uselessness :)
Comment 2 Gilles Dartiguelongue 2007-05-24 19:31:22 UTC
Created attachment 88759 [details] [review]
evolution-widgets-menus.patch

menus subfolder patch
Comment 3 Gilles Dartiguelongue 2007-05-24 19:42:03 UTC
Created attachment 88760 [details] [review]
evolution-widgets-misc.patch

fix in misc subfolder. Removed unused 'format' variables, commented out the one in the new e-spinner functions.
Comment 4 Gilles Dartiguelongue 2007-05-24 19:50:23 UTC
Created attachment 88762 [details] [review]
evolution-widgets-misc.patch

updating misc patch to remove not related Makefile.am changes
Comment 5 Gilles Dartiguelongue 2007-05-24 19:54:13 UTC
Created attachment 88763 [details] [review]
evolution-widgets-misc.patch

damn, sorry for the spam. This should be the good version
Comment 6 Gilles Dartiguelongue 2007-05-24 20:11:36 UTC
Created attachment 88765 [details] [review]
evolution-widgets-table.patch

patch for the table submenu.

one function commented out to check (e-table-group-container.c @1124)
Comment 7 Gilles Dartiguelongue 2007-05-24 20:22:22 UTC
Created attachment 88768 [details] [review]
evolution-widgets-ChangeLog.patch

and here comes the ChangeLog :)
Comment 8 Gilles Dartiguelongue 2007-05-24 20:23:28 UTC
attaching to tracker
Comment 9 Srinivasa Ragavan 2007-05-28 15:55:54 UTC
Looks fine to commit.
Comment 10 Matthew Barnes 2007-06-03 02:45:41 UTC
Committed to Subversion trunk (revision 33626).