GNOME Bugzilla – Bug 440861
Rating Option in the Notification Icon Menu
Last modified: 2007-05-25 05:16:00 UTC
I would like to see a Rating menu in the Notification Area Icon's menu. This way when I want to rate a song I do not need to open Banshee to do it.
Created attachment 88711 [details] [review] Patch for getting Rating menu in the Notification Icon Menu This patch touches the NotificationAreaIconMenu.xml and NotificationAreaIconPlugin.cs to add a Rating menu and submenu to the Notification Area Icon's menu system so that a user can rate a song without having to open Banshee.
Isn't this what the music-applet is for? http://www.kuliniewicz.org/music-applet/
Why have a separate application for something that can easily be added to the main program or included plugin?
Why add something to the main program or a plugin when it already exists? The music-applet is nice because it works equally well with Banshee and Rhythmbox. I'm not a Banshee developer; I can't speak for them as to whether this "should" be added to Banshee. I'm just saying the functionality is already available for GNOME users via this applet. The big draw that I can see for adding it to Banshee itself is that it could be utilized for those that are using Banshee outside of GNOME (Windows, Xfce/KDE).
I'll defer to the maintainers of Banshee on if the patch makes it into trunk, especially since it probably needs some code clean-up. I do not know about anyone else, but I do not like having a bunch of applets open, they take up space on the panel and more importantly, they utilize system resources. The music applet means that not only do I need to be running Banshee or Rhythmbox, but I also need to be running a secondary applet/application to get functionality that is included by default in several popular Windows applications (iTunes, Windows Media Player, and MediaMonkey) by default. The idea in my opinion is to make Banshee work for the largest audience possible, so the more features that can be added to the core of the program to accomplish that, the better. Developers should not require users to install additional applications to get functionality that should be included by default. Doing so means a new user needs to take additional steps to achieve something that should be simple "point & click" behavior. I understand that Banshee is still young in its development, so utilizing something like the music-applet works for the time being so that the core developers can focus on the more important things (memory bugs, browser, & core API). I however am not a core developer so I can take some time to add the little bits that make, not only my life easier, but other users as well.
Created attachment 88771 [details] [review] Better version of Patch (less overall code) This version of the patch utilizes a for loop to building the Ratings actions, instead of having the code per action, per rating. This means overall less code.
An effort to bring this functionality has been tracked in an open bug some time now. I decided I wanted it to be done inline in the menu, eliminating a submenu. This should be described in the original bug. Unfortunately I'm going to have to reject your patch since it is duplicated and not really inline with the points discussed on the duplicate (bug #337157). However, I think that patch needs updating to reflect the usage of the new inline rating menu item, so it might be something for you to do if you want. Thanks for the effort regardless. Just be sure to search bugzilla next time! :) *** This bug has been marked as a duplicate of 337157 ***
As it turned out, the final patch was already posted to the bug, so I have now committed it. This feature is available in trunk.
Awesome, I'll do an update :) Coincidentally, before I submitted my patch, I did a quick check for the "project: banshee rate" and bug 337157 did not come up in the list. *shrugs* I'm happy the feature is added so it's not a big deal that it wasn't my patch. I'm happy though that I was able to code a version of the feature that did not leave the program in an unworkable state, so there's a silver lining.
(In reply to comment #9) > Coincidentally, before I submitted my patch, I did a quick check for the > "project: banshee rate" and bug 337157 did not come up in the list. *shrugs* > I'm happy the feature is added so it's not a big deal that it wasn't my patch. Yeah, bugzilla's searching is a bit nitpicky; drives me nuts. :( > I'm happy though that I was able to code a version of the feature that did not > leave the program in an unworkable state, so there's a silver lining. Well, you're farther ahead than I; I'm still working on getting comfortable in C#. I'd love to hear any tips if you want to email me personally. ;) Sorry for a bit of OT. O:-)