Created attachment 88563 [details] [review]
evolution-addressbook-warning.patch

cast fixes and stuff :)

note that the diff in file gui/contact-editor/e-contact-quick-add.c is because gcc complained it was defined but not used. I commented out the function to see if it will break something but I've not yet finished fixing the rest of the tree so feel free to ignore this part for the moment.

+		/* what to do here ? */
+		mergeit (lookup);
+		break;

Leave it the way it was. I think that should do. I dont think you need to do this.

well the warning was strange and the original code as well :)
Shall I redo the patch and attach it or just don't forget to do that on commit ?

Hmm, I'll do that while committing. Thanks :)

Committed to Subversion trunk (revision 33630) with the hunk mentioned in comment #3 reverted.