After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 440168 - spacing in vertical collection not ideal
spacing in vertical collection not ideal
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: image viewer
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-05-21 12:52 UTC by Sebastien Bacher
Modified: 2007-06-21 22:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Sebastien Bacher 2007-05-21 12:52:34 UTC
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/eog/+bug/111767

"Binary package hint: eog

The new image pane leaves too much dead space between images, when placed vertically. Leaving less space would look better and allow for keeping track of more images in the same space.

Please see attached screenshot and mockup.

http://librarian.launchpad.net/7514537/screenshot.tar.bz2
screenshot and mockup
..."
Comment 1 Felix Riemann 2007-05-23 17:59:50 UTC
Hmm, it appears as if GtkIconView is ignoring the row_spacing setting (which we set to 0 already) in vertical display mode, as setting it to 1000 shows no effect  (while column_spacing does). 
Comment 2 Felix Riemann 2007-05-24 14:00:40 UTC
(In reply to comment #1)
> Hmm, it appears as if GtkIconView is ignoring the row_spacing setting (which we
> set to 0 already) in vertical display mode, as setting it to 1000 shows no
> effect  (while column_spacing does). 
> 

Uhm, no that was just because the row_spacing was reset to 0 later from EogWindow.
Comment 3 Lucas Rocha 2007-06-21 22:51:04 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

2007-06-22  Lucas Rocha  <lucasr@gnome.org>

        Use the same thumbnail frame than nautilus. Fixes bug #441138.

        Change alignment in thumbnail pane to make it work better on vertical
        and horizontal orientations. Fixes bug #440168.

        * src/eog-thumbnail.[ch] (eog_thumbnail_add_frame,
        eog_thumbnail_fit_to_size): added functions to add shadow frame and
        thumbnail resizing.
        * src/eog-thumb-view.c (eog_thumb_view_init): changed the pixbuf
        cell renderer to make improve the aligment among thumbnails.
        * src/eog-plugin-engine.c, src/eog-application.c, src/eog-window.c,
        src/eog-dialog.c, src/Makefile.am: renamed EOG_DATADIR and
        EOG_PLUGINDIR to EOG_DATA_DIR and EOG_PLUGIN_DIR respectively.
        * configure.ac, data/Makefile, data/pixmaps/*: added new pixmap
        for thumbnail frame.
        * src/eog-thumb-shadow.[ch]: removed.