After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438873 - Some G_GNUC_INTERNAL references not moved to start of line
Some G_GNUC_INTERNAL references not moved to start of line
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.13.x
Other Solaris
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2007-05-16 12:06 UTC by Damien Carbery
Modified: 2007-05-17 16:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Move G_GNUC_INTERNAL to start of line for SunStudio compiler support. (4.93 KB, patch)
2007-05-16 12:06 UTC, Damien Carbery 		accepted-commit_now Details | Review

Description Damien Carbery 2007-05-16 12:06:18 UTC 
Related to bug #342981, there are 5 files where G_GNUC_INTERNAL has not been moved to the start of the line.
This requires us in Sun (JDS group) to maintain a local patch to build glib 2.13.x with the SunStudio compiler.

The attached patch moves G_GNUC_INTERNAL to the start of the line.
Comment 1 Damien Carbery 2007-05-16 12:06:46 UTC 
Created attachment 88284 [details] [review]
Move G_GNUC_INTERNAL to start of line for SunStudio compiler support.
Comment 2 Matthias Clasen 2007-05-16 19:31:37 UTC 
Looks fine, please commit
Comment 3 Damien Carbery 2007-05-17 09:08:40 UTC 
I don't have commit access. I let it lapse years ago, before svn.
Comment 4 Matthias Clasen 2007-05-17 16:41:36 UTC 
        * glib/gdebug.h:
        * glib/gmessages.h:
        * glib/gunicodeprivate.h:
        * glib/gthreadprivate.h: Move G_GNUC_INTERNAL before function
        declarations to fix compilation with sun studio.  (#438873,
        Damien Carbery)