After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 438615 - gnome-session logout animation doesn't work with compiz
gnome-session logout animation doesn't work with compiz
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
: 157822 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-15 14:51 UTC by Ray Strode [halfline]
Modified: 2008-04-04 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Disable the animation if compiz is running (1.59 KB, patch)
2007-05-15 14:53 UTC, Ray Strode [halfline] 		committed Details | Review
gnome-session-iris-enabled.patch (594 bytes, patch)
2007-05-22 15:15 UTC, Bastien Nocera 		none Details | Review

Description Ray Strode [halfline] 2007-05-15 14:51:01 UTC 
(from https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=237842)

gnome-session currently grabs the server for the duration of its log out dialog.  This means compiz can't draw to its overlay window and actually show the dialog.
Comment 1 Ray Strode [halfline] 2007-05-15 14:53:57 UTC 
Created attachment 88211 [details] [review]
Disable the animation if compiz is running

I guess we should just let the compositing manager handle the animations if its running.

Bastien filed https://bugs.freedesktop.org/show_bug.cgi?id=10953 on that front.
Comment 2 Vincent Untz 2007-05-15 19:24:02 UTC 
Comment on attachment 88211 [details] [review]
Disable the animation if compiz is running

>-  a11y_enabled = GTK_IS_ACCESSIBLE (gtk_widget_get_accessible (invisible));
>+  iris_effect_enabled = !GTK_IS_ACCESSIBLE (gtk_widget_get_accessible (invisible)) && !gtk_widget_is_composited (invisible);

Nitpick: can you put it this way:
iris_effect_enabled = !GTK_IS_ACCESSIBLE (gtk_widget_get_accessible (invisible)) &&
                      !gtk_widget_is_composited (invisible);

Just wondering: is this a problem only for compiz or for all compositing managers?

Please commit to HEAD and gnome-2-18!
Comment 3 Vincent Untz 2007-05-15 19:25:26 UTC 
*** Bug 157822 has been marked as a duplicate of this bug. ***
Comment 4 Ray Strode [halfline] 2007-05-15 19:38:46 UTC 
Yea, it affects all compositing managers (or rather it affects any program that needs to talk to X while the dialog is up really)
Comment 5 Bastien Nocera 2007-05-22 15:14:08 UTC 
Reopen, it's hanging in metacity now.
Comment 6 Bastien Nocera 2007-05-22 15:15:36 UTC 
Created attachment 88617 [details] [review]
gnome-session-iris-enabled.patch

A couple of ifs were inverted.
Comment 7 Bastien Nocera 2007-05-22 15:30:35 UTC 
2007-05-22  Bastien Nocera  <hadess@hadess.net>

        * logout.c: (display_gui): Fix logic in Ray's patch, thanks Ray for
        noticing :) (Closes: #438615)