GNOME Bugzilla – Bug 436888
[verified] Include widget status information in speech and braille for flat review
Last modified: 2008-07-22 19:27:54 UTC
There's been a lot of discussion on the Orca list regarding flat review not presenting information about widgets, such as progress bar values and checkbox states. To address the braille part of this, we might consider enhancing flat_review.py to include widget status information for braille lines. A possible place to start looking at this would be the getBrailleRegions method for the Line class in flat_review.py. It might look to using the braillegenerator of the script to create braille regions for the accessible of each Zone, meaning it would need to be extended to have some knowledge of the script. In addition, it would probably also need to provide some means to filter out labels that are labelling something on the line since the generator for the thing being labelled would end up picking up the label text.
I'm going to change the summary of this bug as if we are going to provide state in flat review we should do it for both speech and braille.
*** Bug 434594 has been marked as a duplicate of this bug. ***
As part of this work we should also add non-text objects to the flat review context. It is OK if they are treated as a single character for the purpose of moving around in flat review. It would however be nice if the user could still doubleclick "read word" to spell the object.
Created attachment 90535 [details] [review] Patch to support checkboxes, radio buttons, toggle buttons, sliders, scrollbars, and progress bars This patch seems to cover the most common use cases, and it even adds automatic updating of braille for progress bars if you happen to be flat reviewing a progress bar when it is changing.
> moving around in flat review. It would however be nice if the user could still > doubleclick "read word" to spell the object. This should work with the previous patch as well.
> This patch seems to cover the most common use cases, and it even adds automatic > updating of braille for progress bars if you happen to be flat reviewing a > progress bar when it is changing. Note: when applying this patch, you might see the following: patching file src/orca/flat_review.py Hunk #2 FAILED at 22. 1 out of 15 hunks FAILED -- saving rejects to file src/orca/flat_review.py.rej It's just the copyright change that's failing. The rest of the patch should be applied and you can ignore the failure message.
Mike - please try this out. We can tweak it based upon your feedback and then I'll check it in.
Created attachment 90630 [details] [review] Revised patch to handle checkboxes in table cells and progress bar status on lines This patch addresses two problems with the previous patch: 1) The fact that table cells sometimes act like checkboxes, but still call themselves tables cells (a.k.a., the "you can only have one role" problem of AT-SPI) 2) Lines were calculating their string text when initialized. This patch makes the Line calculate its string each time it is requested, allowing us to handle the new dynamic flat review zones.
Mike - please test. Thanks!
Cool! this seems to nicely fix both of the issues we talked about this morning.
Thanks! I've tested this a fair amount. Fingers crossed I didn't introduce any regressions. Closing as FIXED.
Some Information is msssing in flat review: 1. Combos 2. sliders Please have a look to orcas settings->speech tab.
(In reply to comment #12) > Some Information is msssing in flat review: > 1. Combos By design, role information is currently purposely not emitted for comboboxes. > 2. sliders The value/role of non-text objects is currently emitted, but if it has text associated with it (the sliders on the 'speech' tab have their value also presented in text), it is not emitted. I'd like to postpone work on these issues until we work on the new and improved physical/screen mode.