GNOME Bugzilla – Bug 436811
Use C locale fallback instead of en_US
Last modified: 2007-06-28 03:14:05 UTC
Hi, While going over the gdm diff, I found a change which doesn't seem to be Debian specific. It will set the locale to C as fallback instead of en_US. C is guaranteed to be always available, while en_US is not on a lot of systems. (Patch follows) Bye,
Created attachment 87783 [details] [review] Fallback to C locale instead of en_US
This patch doesn't make sense to me, though the original code doesn't look right either. Please respond to comments in bug 89452 which caused this code to get added in the first place. Note that Owen Taylor doesn't believe adding "C" as a failsafe is right. Note that while looping over the locales, we set got_english if there is any language that starts with "en_ or the "C" language. We only set to "en_US" if this is false. As you say, since "C" is always available, and this code is only intended to make GDM work okay if locale.alias is messed up or missing or something. I'd be up for removing this cruft completely if this is causing a problem.
I commented in bug 89452, thanks!
Based on the discussion in bug 89452, I think we should just remove the default logic. According to people the system should default to C without needing to append it to the list. Doesn't seem there is any concensus on what the right default should be, so best to let the system decide. If you want to provide a patch to rip out this defaulting logic, I'll commit it.
Loic, would you be willing to write a patch to remove the default logic? I don't think it is useful.
Created attachment 90732 [details] [review] Removes the default locale selection logic (with ChangeLog) Sure; I hope this patch is enough. It builds here. There are unrelated warnings; are you taking patches to remove unused functions and variables?
Thanks, fixed upstream!