After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436744 - Rhythmbox can't modify existing iPod playlists
Rhythmbox can't modify existing iPod playlists
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
HEAD
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks: 338564
 
 
Reported: 2007-05-08 00:19 UTC by Steven Walter
Modified: 2007-05-09 18:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update itdb playlists when rb playlists are changed (5.47 KB, patch)
2007-05-08 00:20 UTC, Steven Walter 		committed Details | Review
Proposed change (2.05 KB, patch)
2007-05-09 08:07 UTC, Christophe Fergeau 		committed Details | Review

Description Steven Walter 2007-05-08 00:19:00 UTC 
When rhythmbox is started with an ipod attached, the playlists on the ipod appear, as well as the songs on those playlists.  It is possible to drag and drop songs from the ipod to its existing playlists, and this appears to succeed.  However, if the ipod is ejected, the songs do not show up in the ipod menus, and neither do they show up in rhythmbox is the ipod is plugged in again.

Rhythmbox should record changes to an iPod's playlists.
Comment 1 Steven Walter 2007-05-08 00:20:10 UTC 
Created attachment 87762 [details] [review]
Update itdb playlists when rb playlists are changed

Hook onto the row-inserted and entry-removed signals of the RBPlaylist and update the Itdb appropriately
Comment 2 James "Doc" Livingston 2007-05-08 12:55:44 UTC 
Looks okay and works for me, so I've committed it to svn with a small memory leak fix. Thanks.
Comment 3 Christophe Fergeau 2007-05-09 08:03:58 UTC 
Can't find_ipod_track be replaced by a (faster) lookup in priv->entry_map?
Comment 4 Christophe Fergeau 2007-05-09 08:07:02 UTC 
Created attachment 87859 [details] [review]
Proposed change
Comment 5 James "Doc" Livingston 2007-05-09 08:23:40 UTC 
Err, yeah.
Comment 6 Steven Walter 2007-05-09 14:09:27 UTC 
This looks good to me, too.  D'oh.
Comment 7 Christophe Fergeau 2007-05-09 18:49:02 UTC 
I went ahead and committed it.