After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 436148 - Dia mis-handles xfig arcs
Dia mis-handles xfig arcs
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: import
0.96.1
Other Linux
: Normal normal
: 0.98
Assigned To: Dia maintainers
Dia maintainers
: 436350 646262 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-05-05 16:36 UTC by Roland Stigge
Modified: 2011-03-30 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Mentioned fig example file (328 bytes, text/plain)
2007-05-05 16:37 UTC, Roland Stigge
Details
Second example of fig import problem (349 bytes, text/plain)
2007-05-05 16:54 UTC, Roland Stigge
Details

Description Roland Stigge 2007-05-05 16:36:02 UTC
Hi,

a Debian user reported the following:

=============================================================================
In the attached fig file (which was produced by xfig 3.2.5 and then edited
by deleting the second line, "Portrait"), dia puts the arcs on the wrong sides.

In xfig, the arc goes from "1", past "2", to "3",
while in dia, the ends of the arc are (more or less correctly)
near "1" and "3", but the middle is far away from "2".
=============================================================================

I could reproduce this. Does the mentioned manual preparation of fig files (and dia complaining about the xfig import file contents anyway) imply a general xfig import problem?

I'm not sure if this is somehow related to #59941.

See also

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=406722

Thanks,

Roland
Comment 1 Roland Stigge 2007-05-05 16:37:42 UTC
Created attachment 87610 [details]
Mentioned fig example file
Comment 2 Roland Stigge 2007-05-05 16:53:41 UTC
I also get problems on opening other unmodified xfig files as well, see new attachment.

(Also reported as a Debian bug at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=405833)
Comment 3 Roland Stigge 2007-05-05 16:54:47 UTC
Created attachment 87612 [details]
Second example of fig import problem
Comment 4 Lars Clausen 2007-05-18 02:50:07 UTC
*** Bug 436350 has been marked as a duplicate of this bug. ***
Comment 5 Lars Clausen 2007-06-29 16:33:51 UTC
Bug reproduced.  Indeed, there are a number of problems with Fig import, which I fortunately will have some time to work on at work soon.
Comment 6 Hans Breuer 2007-10-13 17:38:45 UTC
can be reproduced with render-test.dia from the Dia distribution as well ...
Comment 7 Hans Breuer 2008-05-04 19:11:56 UTC
Seems as if this is completely fixed in SVN now:

2008-05-04  Hans Breuer  <hans@breuer.org>

	* plug-ins/xfig/xfig-import.c(fig_read_arc): acccept pie-wedge 
	although not completely supported. Better than refusing the whole file
	(fig_read_text) : fixed probable typo 3.54/72.0

	* lib/geometry.[hc] lib/libdia.def: three_point_circle() calculate
	center point and radius given 3 points on a circle, fixed prototype and 
	implementation to ...
	* plug-ins/xfig/xfig-export.c : corrected arc export for both draw_arc 
	and fill_arc methods

	* plug-ins/xfig/xfig-import.c lib/create.h(create_standard_arc) : the 
	fifth parameter was named and treated as radius alsthough it set the
	"curve_distance"
	* lib/create.c(create_standard_arc) : also the second point passed in
	was simply ignored. Now it moves the second handle. Part of bug #436148
Comment 8 Roland Stigge 2010-06-20 20:31:49 UTC
Hi,

unfortunately, dia still produces errors with my "Second example".

Thanks for considering,

bye,
  Roland
Comment 9 Hans Breuer 2011-01-30 20:56:08 UTC
I've just pushed a fix to master which makes Dia read the file without complaints.
http://git.gnome.org/browse/dia/commit/?id=7cebf3c2e7d371dfd10d18f700e75dcef09c0367

But I fail to correlate the files content with this bugs title. It does not contain an arc, but a ployline. Also it seems to be generally broken - maybe because it is created by an alpha version of XFig?
From my understanding every compound has to be closed by -6, so the number of 6 and -6 at lines beginning should match. See:
http://www.xfig.org/userman/fig-format.html

Declaring as fixed. Please provide a non-alpha-version created file, if you still are not satisfied ;)
Comment 10 Hans Breuer 2011-03-30 20:42:40 UTC
*** Bug 646262 has been marked as a duplicate of this bug. ***