GNOME Bugzilla – Bug 435668
[Patch] Make gnome-netstatus more theme friendly
Last modified: 2007-10-07 20:14:56 UTC
Please describe the problem: This patch consists of three parts 2. In the theme-friendly-icons gnome goal: http://live.gnome.org/GnomeGoals/AppIcon We made all apps run gtk-update-icon-cache in install-hook. They also should call it in uninstall-hook. Refer to #362604. 2. Replace custom icon theme code with gtk_window_set_icon_name() in dialog.c 3. Replace custom icon theme code with gtk_window_set_icon_name() in applet.c As of 2.10 gtk_window_set_icon_name() has been able to determine the correct theme. Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 87504 [details] [review] patch to make gnome-netstatus more theme friendly
You typed gnome-netstatus.txt in one place. Other than that it looks good to me. Not sure gnome-netstatus is actively maintained any more though. Maybe mail the listed maintainer and ask for review?
Created attachment 96814 [details] [review] revised: make gnome-netstatus more theme friendly Fixes the mentioned typo and three gcc4 compiler warnings.
Looks fine to commit, thanks
Committed to trunk 2007-10-07 David Farning <dfarning@gmail.com> Patch updated and revised by Christian Kirbach <Christian.Kirbach@googlemail.com> * icons/Makefile.am (update-icon-cache): Fix gtk-update-icon-cache for install-hook and uninstall-hook. * src/netstatus-dialog.c: * src/netstatus-applet.c: Replace custom icon theme code with gtk_window_set_icon_name() and remove unused variables.