GNOME Bugzilla – Bug 435614
Wen DnD rotate left/right icons to "Toolbar Editor" the icon not appear
Last modified: 2007-05-17 08:40:01 UTC
Steps: 1. Open "Toolbar Editor" (Edit->Toolbar); 2. Drag and Drop Left or Right (rotate icons) to the Editor; Expected result: Icon should appear. Result: Only the Label appear.
(eog:18226): Gtk-CRITICAL **: gtk_drag_source_set_icon_pixbuf: assertion `GDK_IS_PIXBUF (pixbuf)' failed (eog:18226): GLib-GObject-CRITICAL **: g_object_unref: assertion `G_IS_OBJECT (object)' failed confirming.
Yes, the toolbar-editor code tries to retrieve the icons using their stock-id. The problem: EOG's rotate and flip icons aren't stock icons, but themed (named) icons. They require a different approach of retrieving them.
I just committed a fix to trunk (rev 3578). 2007-05-05 Felix Riemann <> * cut-n-paste/toolbar-editor/egg-toolbar-editor.c: (event_box_realize_cb), (editor_create_item_from_name): Fix usage of themed icons and have them displayed under the pointer while dragging them to the toolbar. Fixes bug 435614. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report. Please note that you might need to do a "make clean" first before rebuilding as the build system doesn't seem to catch changes in the toolbar editor and thus doesn't update EOG's executable.
Felix, please apply this patch on libegg too so that other EggToolbarEditor users can get this improvement as well. Make sure nothing brakes, of course. :-)
It would be useful to publicite the fix also for people using their local copy of the editable toolbar. Maybe an entry in a blog in p.g.o could be useful, or a heads up in gnome-hackers@gnome.org.
Should I commit it directly or should I open a bug report?
Ah, I read the README. Will submit a patch.
Patch has landed in libegg and epiphany: bug 436684 .
Evince uses toolbar editor too.
The same with "Slideshow". Icon doesn't appear.
True, but that's a different problem. The problem with the slideshow item is that there is no icon set for it yet. See bug 374582 comment 8. Setting back to fixed.