After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 434631 - Focus should automatically switch to message widget after selecting paragraph format
Focus should automatically switch to message widget after selecting paragraph...
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: gtkhtml-maintainers
Evolution QA team
: 442136 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-04-30 15:52 UTC by Matthew Barnes
Modified: 2007-10-02 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed gtkhtml patch (2.72 KB, patch)
2007-09-19 14:17 UTC, Milan Crha
committed Details | Review

Description Matthew Barnes 2007-04-30 15:52:11 UTC
Forwarding from a downstream bug report:
http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236838

When I'm editing a message in evolution and I want to start a numbered list, I
have to click on the drop-down that specifies that paragraph type, and select
"Numbered List".  What *should* happen after I do that is that I should be
automatically bounced back into the message text at the point where my focus was
before I selected the new format, but instead, the format drop-down remains
selected and I have to hit tab or click again to get back into the text area. 
This is broken.
Comment 1 Milan Crha 2007-05-02 07:38:46 UTC
The same is for a font-size chooser and color chooser.
If I could help with this, then there are two different solutions (maybe more, I see these two):
1) simply set "focus-on-click" on FALSE, but it will not work for keyboard selection (Ctrl+Tab to get on toolbar, and then choose value with arrows).
2) add into "set_property" function calling of gtk_widget_grab_focus, but this could work more strangely when calling this function anywhere else then in response of appropriate signal of that combo. Also with keyboard selection, the first approach allow to see result of that change (when you have focused that combo and only change value with arrow up/down without see whole list) and this will not work for this solution, because every time you change value you have focus back in the text area.

I'm not sure which behavior is better, so if I could help you with this then only say which one you prefer (or simply suggest other solution).
BTW, I see there other problem, with that color chooser, it's based on private component and I'm not sure if that component may have this behavior in general. (I mean everywhere where is used.)
Comment 2 André Klapper 2007-05-29 19:05:34 UTC
*** Bug 442136 has been marked as a duplicate of this bug. ***
Comment 3 Paul Smith 2007-07-05 14:41:10 UTC
This is still a problem in Evolution 2.11.4, checked out of SVN head in June 22 2007.
Comment 4 Paul Smith 2007-09-18 19:45:05 UTC
I really wish someone would fix this.  It's uber-annoying.
Comment 5 Milan Crha 2007-09-19 14:17:13 UTC
Created attachment 95851 [details] [review]
proposed gtkhtml patch

for gtkhtml;

After a little discussion about this on IRC I did it as I supposed in comment #1 point 1). The behavior of color chooser (with getting color based on actual selection start) is very weired from my point of view, but it's out of scope of this bug.
Comment 6 Srinivasa Ragavan 2007-09-27 06:47:28 UTC
Milan, just commit to stable and head. 
Comment 7 Milan Crha 2007-09-27 09:03:41 UTC
Committed to trunk. Committed revision 8589.
Committed to stable. Committed revision 8590.
Comment 8 Paul Smith 2007-10-02 22:43:37 UTC
FYI, I just tested this and can confirm it's fixed.

Thanks!