Bug 434193 - Drag and drop in scrolled windows
Drag and drop in scrolled windows
Status: NEW
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.12.x
Other All
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
:
Depends on: 576952
Blocks:
  Show dependency tree
 
Reported: 2007-04-28 19:33 UTC by Sebastian Ärleryd
Modified: 2017-03-08 21:30 UTC (History)
6 users (show)

See Also:
GNOME target: ---
GNOME version: ---


Attachments
We need to redraw the dnd rectangle on scroll event too. (1.92 KB, patch)
2009-03-27 14:01 UTC, Nelson Benitez
needs-work Details | Diff | Review

Description Sebastian Ärleryd 2007-04-28 19:33:39 UTC
When dragging a file in a scrolled nautilus window scrolling with the scroll wheel should work. I have thought about this a lot and this is a feature I would be really happy to see implemented.

Other information:
Comment 1 Sense Hofstede 2007-10-19 15:50:15 UTC
This bug is also reported in the ubuntu bug tracker: https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/104395
and marked as confirmed, wishlist.
It is confirmed, so you could say this one is also confirmed.
(By the way, shouldn't the version be adapted since it also happens in 2.20?)
Comment 2 Nelson Benitez 2008-07-16 12:47:14 UTC
Windows XP has this same bug, would like to know if Vista has it too. That would suggest this is a hard-to-fix bug.
Comment 3 Sebastian Ärleryd 2008-07-16 23:18:53 UTC
I just tried and I can't scroll in explorer when drag and dropping a file under Vista either.
Comment 4 Nelson Benitez 2009-03-27 14:01:05 UTC
Created attachment 131498 [details] [review]
We need to redraw the dnd rectangle on scroll event too.

I've marked this bug as depending in bug 576952, as we need that patch so gtk dnd passes the scroll events to us. But nautilus still has a small glitch in icon view when doing the scrolling (list view works fine), so this small patch fixes it.
Comment 5 Jack Deslippe 2009-05-08 23:39:27 UTC
I reported the bug about the black lines during scrolling when dragging and dropping on launchpad here:  https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/368214

Is this now fixed in nautilus.  (I.e. was your patch accepted?)
Comment 6 Nelson Benitez 2009-05-10 18:21:28 UTC
(In reply to comment #5)
> I reported the bug about the black lines during scrolling when dragging and
> dropping on launchpad here: 
> https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/368214
> 
> Is this now fixed in nautilus.  (I.e. was your patch accepted?)
> 

My patch may help but it doesn't fix your launchpad bug, instead if I run nautilus against git master GTK+ the blacklines are almost gone, but with ubuntu gtk+ they constantly appear, so it could be related to gtk+ themes?, therefore your launchpad bug is not related to my patch, my patch fixes another (more severe) blacklines issue that appears due to my gtk+ patch to support scrolling dnd. 
Comment 7 Cosimo Cecchi 2009-10-08 10:49:35 UTC
Comment on attachment 131498 [details] [review]
We need to redraw the dnd rectangle on scroll event too.

Thanks for the patch.
I am not commenting yet on the semantics of the patch, but code-style-wise, here's some comments:

>+void            dnd_highlight_queue_redraw (GtkWidget      *widget);

If you make the function public, there's no need to have this prototype here.

>+void   dnd_highlight_queue_redraw              (GtkWidget *widget);

Should be nautilus_dnd_highlight_queue_redraw()
Comment 8 Alexandre Franke 2014-12-24 16:29:30 UTC
Nelson, do you think you can update the patch?
Comment 9 Pander 2017-03-08 21:30:10 UTC
Just wanted to report this, but luckily found this report. Hope this can be fixed before it turns 10 years old.

Note You need to log in before you can comment on or make changes to this bug.